20542[BUGFIX] Enable table property for all user settings types
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
-
Verified V +2
- Christian Kuhn +2
Issues 1
Files 1
Review log 17
-
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8699/ : SUCCESS -
Jigal van Hemert updated the commit message in patch set 1 06/07/13, 19:26
-
Mr. Jenkins commented on patch set 2 06/07/13, 19:27
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8993/ : SUCCESS -
Jigal van Hemert commented on patch set 2 V +1 CR +1 06/07/13, 19:34
SetupModuleController.php:494CGL nitpick : indent "case". Can be done before merging. -
Philipp Gampe commented on patch set 2 06/08/13, 15:27
SetupModuleController.php:494Replynot part of this patchset IMHO, I prefer atomic changes -
Jigal van Hemert commented on patch set 2 06/08/13, 15:48
SetupModuleController.php:494Replypolicy is that if you touch a function you take care of CGL problems at the same time -
Wouter Wolters commented on patch set 2 06/08/13, 19:12
SetupModuleController.php:494ReplyIMO that is not a correct policy. That will bump up the patchset to review. I'd suggest to create a ticket and push a seperate patch to improve the CGL. That way it is easier to review both patches. -
Philipp Gampe commented on patch set 2 06/15/13, 12:46
push, needs review and test by anyone -
Philipp Gampe commented on patch set 2 06/16/13, 16:05
You can test with: https://github.com/pgampe/authenticator Check whether user settings [enable] checkbox sets the same field in the backend users table. -
Stefan Neufeind commented on patch set 2 CR +1 06/30/13, 12:40
SetupModuleController.php:494ReplyI agree with Wouter, so I opened a separate ticket for that: http://forge.typo3.org/issues/49527 It looks like several files are affected and imho it's easier to do them all in one easy patch. -
Patrick Schriner voted on patch set 2 V +1 CR +1 07/05/13, 20:09
-
Philipp Gampe voted on patch set 2 V +2 CR +2 07/05/13, 20:40
-
Christian Kuhn uploaded patch set 3 07/05/13, 21:21
-
Christian Kuhn commented on patch set 3 V +2 CR +2 07/05/13, 21:21
rebased, no code change, votes complete, merged. -
Christian Kuhn merged patch set 4 07/05/13, 21:21
-
Mr. Jenkins commented on patch set 3 07/05/13, 21:22
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9431/ : SUCCESS -
Philipp Gampe commented on patch set 4 07/05/13, 21:26
Cherry Picked This patchset was cherry picked to change: Icf69d480013ff1be6c0b5d43212c179468885344