Review main Merged

20561[TASK][INSTALL] Extract status objects to own namespace

Christian Kuhn CR +2 V +2 Hard +377 −178 updated 06/03/13, 20:49

Commit message

With 6.1 status classes were introduced within the system environment
check that represent the different fail severities.

These objects are pretty useful within ext:install and could be used
as common helper encapsulating all status tasks.

The patch moves the status classes out of the system environment
check to an own namespace within ext:install and adds a utility class
that helps with rendering, filtering and sorting.

Review

  • Code review CR +2
    • Philipp Gampe +2
    • Wouter Wolters +1
  • Verified V +2
    • Philipp Gampe +2
    • Wouter Wolters +1

Issues 1

Files 13

Review log 12

  1. Christian Kuhn commented on patch set 1 05/07/13, 19:13

    I would prefer that you didn't submit this -1 for now: Code fully works already, but the utility class should get some happy little tests.

    StatusUtility.php:67 Reply

    yep.

    StatusUtility.php:92 Reply

    no, performance is not a problem here, the code is very clean and readable, lets keep it this way.
  2. Christian Kuhn uploaded patch set 2 05/07/13, 19:13

  3. Markus Klein commented on patch set 3 05/07/13, 19:13

    (2 inline comments)

    StatusUtility.php:67

    Why not moving that directly into the sprintf() call?

    StatusUtility.php:92

    I don't like the idea of iterating over all status objects everytime. Lets combine that into one single foreach loop
  4. Christian Kuhn commented on patch set 3 05/07/13, 19:13

    (2 inline comments)
  5. Christian Kuhn commented on patch set 3 05/07/13, 19:13

    Ready for review now. Test: * System environment check still works * Reports module still gives sane result for environment checks * Unit tests run
  6. Christian Kuhn uploaded patch set 3 05/07/13, 19:13

  7. Mr. Jenkins commented on patch set 1 05/07/13, 19:13

  8. Mr. Jenkins commented on patch set 2 05/07/13, 19:13

  9. Mr. Jenkins commented on patch set 3 05/07/13, 19:13

  10. Wouter Wolters commented on patch set 3 05/07/13, 19:13

    Verified; Looks good to me, but someone else must approve Tested the module and reports. And ran the unit-tests for ext:install
  11. Philipp Gampe commented on patch set 3 V 0 05/07/13, 19:13

    by team member; Looks good to me, approved
  12. Philipp Gampe merged patch set 4 05/07/13, 19:13