20561[TASK][INSTALL] Extract status objects to own namespace
Commit message
Review
-
Code review CR +2
- Philipp Gampe +2
- Wouter Wolters +1
-
Verified V +2
- Philipp Gampe +2
- Wouter Wolters +1
Issues 1
Files 13
- typo3/sysext/install/Classes/Report/EnvironmentStatusReport.php+1 −1
- typo3/sysext/install/Classes/Status/AbstractStatus.phprenamed+1 −1
- typo3/sysext/install/Classes/Status/ErrorStatus.phprenamed+1 −1
- typo3/sysext/install/Classes/Status/Exception.phpcopied+3 −10
- typo3/sysext/install/Classes/Status/InfoStatus.phprenamed+1 −1
- typo3/sysext/install/Classes/Status/NoticeStatus.phprenamed+1 −1
- typo3/sysext/install/Classes/Status/OkStatus.phprenamed+1 −1
- typo3/sysext/install/Classes/Status/StatusInterface.phprenamed+6 −2
- typo3/sysext/install/Classes/Status/StatusUtility.php4new+121 −0
- typo3/sysext/install/Classes/Status/WarningStatus.phprenamed+1 −1
- typo3/sysext/install/Classes/SystemEnvironment/Check.php+121 −119
- typo3/sysext/install/Classes/Installer.php+7 −40
- typo3/sysext/install/Tests/Unit/Status/StatusUtilityTest.phpnew+112 −0
Review log 12
-
Christian Kuhn commented on patch set 1 05/07/13, 19:13
I would prefer that you didn't submit this -1 for now: Code fully works already, but the utility class should get some happy little tests.StatusUtility.php:67Replyyep.StatusUtility.php:92Replyno, performance is not a problem here, the code is very clean and readable, lets keep it this way. -
Christian Kuhn uploaded patch set 2 05/07/13, 19:13
-
Markus Klein commented on patch set 3 05/07/13, 19:13
(2 inline comments)StatusUtility.php:67Why not moving that directly into the sprintf() call?StatusUtility.php:92I don't like the idea of iterating over all status objects everytime. Lets combine that into one single foreach loop -
Christian Kuhn commented on patch set 3 05/07/13, 19:13
(2 inline comments) -
Christian Kuhn commented on patch set 3 05/07/13, 19:13
Ready for review now. Test: * System environment check still works * Reports module still gives sane result for environment checks * Unit tests run -
Christian Kuhn uploaded patch set 3 05/07/13, 19:13
-
Mr. Jenkins commented on patch set 1 05/07/13, 19:13
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8708/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/07/13, 19:13
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8722/ : SUCCESS -
Mr. Jenkins commented on patch set 3 05/07/13, 19:13
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8723/ : SUCCESS -
Wouter Wolters commented on patch set 3 05/07/13, 19:13
Verified; Looks good to me, but someone else must approve Tested the module and reports. And ran the unit-tests for ext:install -
Philipp Gampe commented on patch set 3 V 0 05/07/13, 19:13
by team member; Looks good to me, approved -
Philipp Gampe merged patch set 4 05/07/13, 19:13