Review main Merged

20562[BUGFIX] Fix broken edit icons on cType HTML

Loek Hilgersom CR +2 V +2 Easy +22 −11 updated 11/13/13, 20:28

Commit message

Fix the wrong Typoscript configuration for front-end edit icons
for cType HTML (for the traditional fe-editing).

Review

  • Code review CR +2
    • Markus Klein +2
    • Stefan Neufeind +1
  • Verified V +2
    • Markus Klein +2
    • Stefan Neufeind +1

Issues 1

Files 11

Review log 12

  1. Stefan Neufeind commented on patch set 1 05/27/13, 17:19

    Verified; Looks good to me, but someone else must approve nice catch. Obvious and works as expected.
  2. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  3. Stefan Neufeind commented on patch set 1 11/11/13, 18:05

    !!! Same fix is also needed against the various setup.txt included with each release - for example typo3/sysext/css_styled_content/static/v6.1/setup.txt
  4. Pascal Dürsteler voted on patch set 1 V +1 CR +1 11/12/13, 08:15

  5. Stefan Neufeind commented on patch set 1 11/12/13, 08:17

    adding this comment here since I hope it catches more attention: !!! Before merge: Same fix is also needed against the various setup.txt included with each release - for example typo3/sysext/css_styled_content/static/v6.1/setup.txt
  6. Markus Klein commented on patch set 1 11/12/13, 15:49

    What is todo here? Add this change to all setup.txt files?
  7. Stefan Neufeind commented on patch set 1 11/12/13, 18:22

    Yes imho. The same in all files. I just didn't do it yet, since I thouhgt we might want to review the (one) change itself and do the rest right before merge or so.
  8. Stefan Neufeind uploaded patch set 2 11/13/13, 19:20

  9. Stefan Neufeind commented on patch set 2 V +1 CR +1 11/13/13, 19:21

    Same patch for the main setup.txt (so Pascals votes still count - sort of). I just added it to the setup.txt-files for older compat-versions as well. Please judge.
  10. Mr. Jenkins commented on patch set 2 11/13/13, 19:33

  11. Markus Klein voted on patch set 2 V +2 CR +2 11/13/13, 20:28

  12. Markus Klein merged patch set 3 11/13/13, 20:28