20562[BUGFIX] Fix broken edit icons on cType HTML
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Stefan Neufeind +1
-
Verified V +2
- Markus Klein +2
- Stefan Neufeind +1
Issues 1
Files 11
- typo3/sysext/css_styled_content/static/v3.8/setup.txt+2 −1
- typo3/sysext/css_styled_content/static/v3.9/setup.txt+2 −1
- typo3/sysext/css_styled_content/static/v4.2/setup.txt+2 −1
- typo3/sysext/css_styled_content/static/v4.3/setup.txt+2 −1
- typo3/sysext/css_styled_content/static/v4.4/setup.txt+2 −1
- typo3/sysext/css_styled_content/static/v4.5/setup.txt+2 −1
- typo3/sysext/css_styled_content/static/v4.6/setup.txt+2 −1
- typo3/sysext/css_styled_content/static/v4.7/setup.txt+2 −1
- typo3/sysext/css_styled_content/static/v6.0/setup.txt+2 −1
- typo3/sysext/css_styled_content/static/v6.1/setup.txt+2 −1
- typo3/sysext/css_styled_content/static/setup.txt+2 −1
Review log 12
-
Stefan Neufeind commented on patch set 1 05/27/13, 17:19
Verified; Looks good to me, but someone else must approve nice catch. Obvious and works as expected. -
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8710/ : SUCCESS -
Stefan Neufeind commented on patch set 1 11/11/13, 18:05
!!! Same fix is also needed against the various setup.txt included with each release - for example typo3/sysext/css_styled_content/static/v6.1/setup.txt -
Pascal Dürsteler voted on patch set 1 V +1 CR +1 11/12/13, 08:15
-
Stefan Neufeind commented on patch set 1 11/12/13, 08:17
adding this comment here since I hope it catches more attention: !!! Before merge: Same fix is also needed against the various setup.txt included with each release - for example typo3/sysext/css_styled_content/static/v6.1/setup.txt -
Markus Klein commented on patch set 1 11/12/13, 15:49
What is todo here? Add this change to all setup.txt files? -
Stefan Neufeind commented on patch set 1 11/12/13, 18:22
Yes imho. The same in all files. I just didn't do it yet, since I thouhgt we might want to review the (one) change itself and do the rest right before merge or so. -
Stefan Neufeind uploaded patch set 2 11/13/13, 19:20
-
Stefan Neufeind commented on patch set 2 V +1 CR +1 11/13/13, 19:21
Same patch for the main setup.txt (so Pascals votes still count - sort of). I just added it to the setup.txt-files for older compat-versions as well. Please judge. -
Mr. Jenkins commented on patch set 2 11/13/13, 19:33
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/12059/ : SUCCESS -
Markus Klein voted on patch set 2 V +2 CR +2 11/13/13, 20:28
-
Markus Klein merged patch set 3 11/13/13, 20:28