20654[FEATURE] Introduce Share font to backend for H1
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Wouter Wolters +1
- Philipp Gampe +1
-
Verified V +2
- Christian Kuhn +2
- Wouter Wolters +1
- Philipp Gampe +1
Issues 1
Files 16
- typo3/sysext/t3skin/Resources/Public/Fonts/generator_config.txtnew+5 −0
- typo3/sysext/t3skin/Resources/Public/Fonts/share-bold-webfont.eotnewbinary
- typo3/sysext/t3skin/Resources/Public/Fonts/share-bold-webfont.svgnew+231 −0
- typo3/sysext/t3skin/Resources/Public/Fonts/share-bold-webfont.ttfnewbinary
- typo3/sysext/t3skin/Resources/Public/Fonts/share-bold-webfont.woffnewbinary
- typo3/sysext/t3skin/Resources/Public/Fonts/share-italic-webfont.eotnewbinary
- typo3/sysext/t3skin/Resources/Public/Fonts/share-italic-webfont.svgnew+231 −0
- typo3/sysext/t3skin/Resources/Public/Fonts/share-italic-webfont.ttfnewbinary
- typo3/sysext/t3skin/Resources/Public/Fonts/share-italic-webfont.woffnewbinary
- typo3/sysext/t3skin/Resources/Public/Fonts/share-regular-webfont.eotnewbinary
- typo3/sysext/t3skin/Resources/Public/Fonts/share-regular-webfont.svgnew+231 −0
- typo3/sysext/t3skin/Resources/Public/Fonts/share-regular-webfont.ttfnewbinary
- typo3/sysext/t3skin/Resources/Public/Fonts/share-regular-webfont.woffnewbinary
- typo3/sysext/t3skin/stylesheets/structure/main_content.css1+3 −2
- typo3/sysext/t3skin/stylesheets/visual/fonts.cssnew+34 −0
- typo3/sysext/t3skin/stylesheets/visual/main_content.css+4 −1
Review log 27
Show 2 earlier messages
-
Felix Kopp uploaded patch set 2 05/18/13, 17:14
-
Felix Kopp commented on patch set 3 05/18/13, 17:14
I would prefer that you didn't submit this resources seems wrinkled -
Ernesto Baschny commented on patch set 4 05/18/13, 17:14
(1 inline comment) Why do we need to add the .zip file to our src? It just contains garbage generated by FontSquirrel, it's irrelevant and of no use to the Core. And why having the "share.js" with Cufon.registerFont which are not being used? Get rid of this garbage too. And also fix the Fonts.css file as inline-commented. -
Ernesto Baschny commented on patch set 4 05/18/13, 17:14
We also need to take care of checking if the Share font license (http://creativecommons.org/licenses/by-nd/2.5/) is compatible to be released in our GPLv2 product. This might be a task for the T3A "Licensing Team" to solve or figure out. Just need to be checked (make an issue for it...). -
Philipp Gampe commented on patch set 4 05/18/13, 17:14
(1 inline comment)main_content.css:21hm, is that comment still valid :D -
Philipp Gampe commented on patch set 4 05/18/13, 17:14
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 4 05/18/13, 17:14
only tested via Chrome (on Linux) -
Felix Kopp uploaded patch set 4 05/18/13, 17:14
-
Mr. Jenkins commented on patch set 1 05/18/13, 17:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8744/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/18/13, 17:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8760/ : SUCCESS -
Mr. Jenkins commented on patch set 3 05/18/13, 17:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8776/ : SUCCESS -
Mr. Jenkins commented on patch set 4 05/18/13, 17:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8799/ : SUCCESS -
Wouter Wolters commented on patch set 2 05/18/13, 17:14
is resources with lowercase first letter correct here? -
Wouter Wolters commented on patch set 4 05/18/13, 17:14
Verified; Looks good to me, but someone else must approve Tested in IE7-IE10 and FF newest version. -
Ernesto Baschny commented on patch set 5 05/18/13, 17:14
I would prefer that you didn't submit this Also I don't see Fonts.css being included anywhere. I see "Verdana" Font for H1. How come you have tested it and seen the Share font in action? Any thing that I miss? -
Ernesto Baschny uploaded patch set 6 05/18/13, 17:14
-
Ernesto Baschny commented on patch set 6 05/18/13, 17:14
Okey, all *css files are merged in this folder, so it was being included. Trouble was that you added the fonts into "resources/Public", while the directory is called "Resources/Public" (upper case). It probably doesn't matter on your dev machine (MacOS - case insensitive), but it doesn't work on Linux. Patchset 5 also removes the ugly and unused zip and .js file. -
Philipp Gampe commented on patch set 6 05/18/13, 17:14
Verified; Looks good to me, but someone else must approve Tested on linux with Chrome and Opera -
Mr. Jenkins commented on patch set 5 05/18/13, 17:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8812/ : SUCCESS -
Mr. Jenkins commented on patch set 6 05/18/13, 17:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8818/ : SUCCESS -
Wouter Wolters commented on patch set 5 05/18/13, 17:14
This one is pushed by accident.. Please see Ernesto his comments! -
Wouter Wolters uploaded patch set 5 05/18/13, 17:14
-
Wouter Wolters commented on patch set 6 05/18/13, 17:14
Verified; Looks good to me, but someone else must approve Hmm I had a wrong look at the previous patchset. There the font appeared in Firebug but wasn't loaded and the fallback to Verdana was in action. Now tested again in IE7-IE10 and FF newest. -
Christian Kuhn commented on patch set 6 V 0 05/18/13, 17:14
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 7 05/18/13, 17:14