20732[BUGFIX] Cannot connect to the current database
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Alexander Opitz +1
- Dmitry Dulepov +1
-
Verified V +2
- Christian Kuhn +2
- Alexander Opitz +1
- Dmitry Dulepov +1
Files 1
Review log 8
-
Dmitry Dulepov uploaded patch set 2 05/16/13, 18:50
-
Dmitry Dulepov commented on patch set 2 05/16/13, 18:50
Verified; Looks good to me, but someone else must approve -
Markus Klein commented on patch set 1 05/16/13, 18:50
(2 inline comments)6.2 too? (you pushed to master...)DatabaseConnection.php:1296Lets describe _why_ we have to catch this exception here. e.g. Catch exception to avoid error message for inaccessible databases. -
Alexander Opitz commented on patch set 2 05/16/13, 18:50
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 05/16/13, 18:50
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8781/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/16/13, 18:50
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8795/ : SUCCESS -
Christian Kuhn commented on patch set 2 V 0 05/16/13, 18:50
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 3 05/16/13, 18:50