Review main Merged

20772[TASK] Hide func menu with only one entry

Georg Ringer CR +2 V +2 Easy +25 −23 updated 06/03/13, 20:49

Commit message

The func menu in a module is used to switch between different views in
the same module.

However if only one item is available, there is no reason to show the
function menu at all.
Also the onchange handler does not work as nothing is changeable.

Count the number of elements and suppress the selector if there is only
one item.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Dmitry Dulepov +2
    • Philipp Gampe +1
  • Verified V +2
    • Wouter Wolters +2
    • Dmitry Dulepov +2
    • Philipp Gampe +1

Issues 1

Files 1

Review log 14

  1. Dmitry Dulepov commented on patch set 1 05/20/13, 13:19

    May be, it makes sense to change getFuncMenu() to return empty string in such cases? This may cause issues if there is a label in front of the selector but usually there is none.
  2. Felix Kopp commented on patch set 1 05/20/13, 13:19

    Would like to have this solved for all function menus. Should be integrate an output condition for all menus?
  3. Felix Kopp commented on patch set 1 05/20/13, 13:19

    There is a count within BackendUtility::getFuncMenu. Shall we extend the functionality over there?
  4. Philipp Gampe commented on patch set 2 05/20/13, 13:19

    I would prefer that you didn't submit this the commit message needs an update, will do this once I review this
  5. Dmitry Dulepov commented on patch set 3 V 0 05/20/13, 13:19

    by team member; Looks good to me, approved Tested, works.
  6. Philipp Gampe uploaded patch set 3 05/20/13, 13:19

  7. Philipp Gampe commented on patch set 3 05/20/13, 13:19

    Verified; Looks good to me, but someone else must approve I updated the commit message.
  8. Felix Kopp commented on patch set 2 05/20/13, 13:19

    This patch changes the visual behaviour of function menus.
  9. Felix Kopp uploaded patch set 2 05/20/13, 13:19

  10. Mr. Jenkins commented on patch set 1 05/20/13, 13:19

  11. Mr. Jenkins commented on patch set 2 05/20/13, 13:19

  12. Mr. Jenkins commented on patch set 3 05/20/13, 13:19

  13. Wouter Wolters commented on patch set 3 V 0 05/20/13, 13:19

    by team member; Looks good to me, approved
  14. Wouter Wolters merged patch set 4 05/20/13, 13:19