Review main Merged

2079[BUGFIX] Fix stdWrap for Click-to-enlarge

Markus Klein CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

Due to a syntax error, stdWrap for the target attribute of
the click-to-enlarge image link is broken. (Nobrainer)

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Björn Pedersen +1
    • Stefano Kowalke +1
  • Verified V +2
    • Xavier Perseguers +2
    • Stefano Kowalke +1

Issues 1

Files 1

Review log 15

  1. Markus Klein uploaded patch set 2 05/12/11, 11:59

  2. Markus Klein uploaded patch set 3 05/12/11, 11:59

  3. Markus Klein commented on patch set 3 05/12/11, 11:59

    Restored Sorry, I just wanted to remove this Patch Set
  4. Markus Klein commented on patch set 3 05/12/11, 11:59

    Abandoned Wrong push.
  5. Björn Pedersen commented on patch set 4 05/12/11, 11:59

    Looks good to me, but someone else must approve
  6. Markus Klein uploaded patch set 4 05/12/11, 11:59

  7. Helmut Hummel commented on patch set 1 V 0 05/12/11, 11:59

    Since the commit message stay in the history forever, could you please write it a little bit more descriptive? Other than that, it's a real nobrainer. I could also not find the review request for the 4-5 branch, could you push this fix for that branch also please?
  8. Stefano Kowalke commented on patch set 4 05/12/11, 11:59

    Verified; Looks good to me, but someone else must approve
  9. Mr. Jenkins commented on patch set 1 05/12/11, 11:59

  10. Mr. Jenkins commented on patch set 2 05/12/11, 11:59

  11. Mr. Jenkins commented on patch set 3 05/12/11, 11:59

  12. Mr. Jenkins commented on patch set 4 05/12/11, 11:59

    Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/483/ : FAILURE
  13. Mr. Jenkins commented on patch set 4 05/12/11, 11:59

    No score; No score ci.typo3.org gives 502. I checked it manually and it looks good.
  14. Xavier Perseguers commented on patch set 4 V 0 05/12/11, 11:59

    by team member; Looks good to me, approved
  15. Xavier Perseguers merged patch set 4 05/12/11, 11:59