20839[BUGFIX] MailUtility::parseAddresses() returns @localhost on empty string
Commit message
Review
-
Code review CR -1
- Jigal van Hemert +2
- Stefan Neufeind -1
- Wouter Wolters +1
-
Verified V +2
- Jigal van Hemert +2
- Wouter Wolters +1
- Philipp Gampe +1
Issues 1
Files 2
Review log 17
-
Stefan Neufeind commented on patch set 1 05/19/13, 09:29
(1 inline comment) In general fine. I'd just suggest to replace the empty()-check.MailUtility.php:245check for an empty String. What if somebody has "000" as mailbox-name? Hypothetical I know :-) but anyway. -
Alexander Opitz commented on patch set 1 05/19/13, 09:29
Looks good to me, but someone else must approve -
Alexander Opitz commented on patch set 1 V 0 05/19/13, 09:29
This is the verified from the issue reporter. -
Philipp Gampe commented on patch set 1 05/19/13, 09:29
I would prefer that you didn't submit thisMailUtility.php:245Replyok -
Joerg Schoppet commented on patch set 1 05/19/13, 09:29
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 05/19/13, 09:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8796/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/19/13, 09:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8816/ : SUCCESS -
Wouter Wolters uploaded patch set 2 05/19/13, 09:29
-
Stefan Neufeind commented on patch set 3 05/19/13, 09:29
I would prefer that you didn't submit this Sorry for being late with a closer look into this. Should this check (leaving out empty addresses after split) maybe go into the address-parser (Rfc822AddressesParser) directly? It might be that other parts use that parser as well and would benefit from having the fix "early in the chain". The comments there say it came from the PEAR::Mail-package but was "adopted" for TYPO3-use. So imho it's not really a contrib-package that we're not allowed to change - actually it's incorporated inside the TYPO3-sources. So I feel changing it there might be a better option. Besides that: This parser exists down to 4.5 and thus the issue of at least getting empty addresses back I expect. And SwiftMailer is used with the "new mail-API" since 4.5 as well. -
Jigal van Hemert commented on patch set 3 V 0 05/19/13, 09:29
by team member; Looks good to me, approved @Stefan: the parser was only used in the SwiftMailerAdapter, which is deprecated as of 6.1. RMs of earlier releases agreed that we should not spend time fixing that adapter anymore. This is IMO the correct place to fix this. The only test in code that uses MailUtility::parseAddresses() should be if there are any addresses left after parsing them. This patch makes sure that this can be done. Maybe we should add such a check in sendNotifyEmail()? Can someone take care of the backport, please? I'm not able to this in the next couple of days. -
Jigal van Hemert merged patch set 4 05/19/13, 09:29
-
Philipp Gampe commented on patch set 3 05/19/13, 09:29
No score should not vote for my own patch ;) -
Philipp Gampe commented on patch set 3 05/19/13, 09:29
Verified; Looks good to me, but someone else must approve thanks for the unit tests -
Mr. Jenkins commented on patch set 3 05/19/13, 09:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8817/ : SUCCESS -
Wouter Wolters uploaded patch set 3 05/19/13, 09:29
-
Wouter Wolters commented on patch set 3 05/19/13, 09:29
Verified; Looks good to me, but someone else must approve Unit-test is mostly copied from SwiftMaileradapter so IMO my vote is valid:) -
Philipp Gampe commented on patch set 4 05/19/13, 09:29
I will do the backport