Review TYPO3_6-0 Abandoned

20849[BUGFIX] Cannot connect to the current database

Christian Kuhn CR 0 V 0 Easy +8 −2 updated 09/26/13, 18:07

Commit message

DatabaseConnection::admin_get_dbs() iterates over all existing
databases during install process and tries to use each of them.
If that fails, an exception is thrown - which is not caught in
the mentioned method.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 6

  1. Steffen Müller commented on patch set 1 05/27/13, 17:19

    I tried hard to reproduce, but somehow was not able to setup a dummy package for 6.0. I either run into plain error message "Neither typo3conf/LocalConfiguration.php (recommended) nor typo3conf/localconf.php (obsolete) could be found!" or directly see the install tool login prompt instead of 1-2-3- mode. (though using typo3/install/index.php?TYPO3_INSTALL[type]=config&mode=123&step=1)
  2. Steffen Müller commented on patch set 1 05/27/13, 17:19

    I finaly managed set up a blankpackage with 6.0.5. I could not reproduce the issue. 1. I set up a DB user with SHOW DATABASES priviledge only. 2. I extracted the blankpackage from tgz 3. I went to website and entered user credentials in step 1 of 1-2-3 install tool 4. I can see step 2, with "select database" dropdown, which contains no items (expected result) This is how I understood the logic: admin_get_dbs() calls $this->sql_select_db($TYPO3_db) which calls @mysql_select_db() which suppresses errors. The sysLog() call logs nothing because logging is obviously not yet configured at this stage. Where did the fatal errors message come from? How to reproduce this issue?
  3. Christian Kuhn commented on patch set 1 05/27/13, 17:19

    Patch is pretty easy, but still different from 6.1 and master version. Please reviow.
  4. Philipp Gampe commented on patch set 1 05/27/13, 17:19

    Looks good to me, but someone else must approve
  5. Stefan Neufeind commented on patch set 1 CR -1 08/22/13, 20:24

    I also read from the docs that in 6.1 mysqli also does not throw an exception when trying to select a db which then fails. http://de3.php.net/manual/de/mysqli.select-db.php So where did the exception originate from? And in which way is 6.0 (using mysql, not mysqli) maybe different?
  6. Christian Kuhn abandoned the change 09/26/13, 18:07

    ok, seems this one is obsolete in 6.0