Review main Merged

20850[BUGFIX] File upload in RTE-Link-Editor throws 500 error

Philipp Gampe CR +2 V +2 Easy +47 −2 updated 07/07/13, 00:01

Commit message

When you want to add a link in the RTE-Editor, you can upload files in
the "File" tab. When you select a file and want to upload it, the
reloaded content in the create-link-overlay will throw an error.

The method is feed with a translation of "none - new file".

Bypass the file or folder lookup if we do not have an integer id
and print the message instead.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1

Issues 1

Files 3

Review log 22

  1. Philipp Gampe commented on patch set 1 05/27/13, 17:19

    Please note that the unit test is not yet activated in the default test suite for Travis. This needs to happen in another change request once this is merged (as this is the first unit test for this sysext).
  2. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  3. Philipp Gampe commented on patch set 1 06/15/13, 12:45

    push
  4. Philipp Gampe uploaded patch set 2 07/05/13, 21:18

  5. Mr. Jenkins commented on patch set 2 07/05/13, 21:19

  6. Steffen Ritter updated the commit message in patch set 2 07/06/13, 14:42

  7. Mr. Jenkins commented on patch set 3 07/06/13, 14:43

  8. Wouter Wolters uploaded patch set 4 07/06/13, 16:07

  9. Mr. Jenkins commented on patch set 4 07/06/13, 16:09

  10. Wouter Wolters commented on patch set 4 V +1 CR +1 07/06/13, 16:10

    Removed not used code from the Unit-Test
  11. Patrick Schriner commented on patch set 4 V +1 07/06/13, 16:30

    I'd prefer if the unit test would only use assertContains and not assertEquals - the later introduces an unneeded tight coupling to the the code output
  12. Stefan Neufeind commented on patch set 4 V +1 CR +1 07/06/13, 21:55

    Didn't try to test the unit-test but actually tested in BE.
    lookup
  13. Philipp Gampe commented on patch set 4 07/06/13, 23:29

    Reply

    Done
  14. Philipp Gampe uploaded patch set 5 07/06/13, 23:29

  15. Philipp Gampe commented on patch set 4 07/06/13, 23:30

    Took comment from Patrick into account.
  16. Mr. Jenkins commented on patch set 5 07/06/13, 23:30

  17. Wouter Wolters commented on patch set 5 CR -1 07/06/13, 23:33

    ElementBrowserTest.php:39

    tab -> space
  18. Philipp Gampe uploaded patch set 6 07/06/13, 23:38

  19. Mr. Jenkins commented on patch set 6 07/06/13, 23:39

  20. Christian Kuhn voted on patch set 6 V +1 CR +1 07/06/13, 23:40

  21. Wouter Wolters commented on patch set 6 V +2 CR +2 07/07/13, 00:01

    Tested.
  22. Wouter Wolters merged patch set 7 07/07/13, 00:01