20850[BUGFIX] File upload in RTE-Link-Editor throws 500 error
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Christian Kuhn +1
-
Verified V +2
- Wouter Wolters +2
- Christian Kuhn +1
Issues 1
Files 3
Review log 22
-
Philipp Gampe commented on patch set 1 05/27/13, 17:19
Please note that the unit test is not yet activated in the default test suite for Travis. This needs to happen in another change request once this is merged (as this is the first unit test for this sysext). -
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8798/ : SUCCESS -
Philipp Gampe commented on patch set 1 06/15/13, 12:45
push -
Philipp Gampe uploaded patch set 2 07/05/13, 21:18
-
Mr. Jenkins commented on patch set 2 07/05/13, 21:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9430/ : SUCCESS -
Steffen Ritter updated the commit message in patch set 2 07/06/13, 14:42
-
Mr. Jenkins commented on patch set 3 07/06/13, 14:43
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9465/ : SUCCESS -
Wouter Wolters uploaded patch set 4 07/06/13, 16:07
-
Mr. Jenkins commented on patch set 4 07/06/13, 16:09
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9485/ : SUCCESS -
Wouter Wolters commented on patch set 4 V +1 CR +1 07/06/13, 16:10
Removed not used code from the Unit-Test -
Patrick Schriner commented on patch set 4 V +1 07/06/13, 16:30
I'd prefer if the unit test would only use assertContains and not assertEquals - the later introduces an unneeded tight coupling to the the code output -
Stefan Neufeind commented on patch set 4 V +1 CR +1 07/06/13, 21:55
Didn't try to test the unit-test but actually tested in BE.lookup -
Philipp Gampe commented on patch set 4 07/06/13, 23:29
Reply
Done -
Philipp Gampe uploaded patch set 5 07/06/13, 23:29
-
Philipp Gampe commented on patch set 4 07/06/13, 23:30
Took comment from Patrick into account. -
Mr. Jenkins commented on patch set 5 07/06/13, 23:30
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9511/ : SUCCESS -
Wouter Wolters commented on patch set 5 CR -1 07/06/13, 23:33
ElementBrowserTest.php:39tab -> space -
Philipp Gampe uploaded patch set 6 07/06/13, 23:38
-
Mr. Jenkins commented on patch set 6 07/06/13, 23:39
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9513/ : SUCCESS -
Christian Kuhn voted on patch set 6 V +1 CR +1 07/06/13, 23:40
-
Wouter Wolters commented on patch set 6 V +2 CR +2 07/07/13, 00:01
Tested. -
Wouter Wolters merged patch set 7 07/07/13, 00:01