20856[TASK] Update phpdoc of pi_getPageLink/pi_linkToPage
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
-
Verified V +2
- Wouter Wolters +2
Issues 1
Files 1
Review log 7
-
Stefan Neufeind commented on patch set 1 05/19/13, 16:23
What is to be escaped and what not just came up in https://review.typo3.org/17176 which adds rawencode() for the parameter-keys. Imho it's a good idea to clarify that in phpdoc, especially since it's already clear in the function that is being called. -
Philipp Gampe commented on patch set 1 05/19/13, 16:23
Verified; Looks good to me, but someone else must approveAbstractPlugin.php:284add an @see TYPO3::CMS::Frontend::ContentObject::ContentObjectRenderer::getTypoLink() to generate a link to the function for the API referenceAbstractPlugin.php:301same here -
Mr. Jenkins commented on patch set 1 05/19/13, 16:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8800/ : SUCCESS -
Wouter Wolters uploaded patch set 2 05/19/13, 16:23
-
Wouter Wolters uploaded patch set 3 05/19/13, 16:23
-
Wouter Wolters commented on patch set 3 V 0 05/19/13, 16:23
by team member; Looks good to me, approved Added the @see as mentioned -
Wouter Wolters merged patch set 4 05/19/13, 16:23