Review main Merged

20857[BUGFIX] Paste button missing in empty folders

Philipp Gampe CR +2 V +2 Easy +8 −2 updated 06/03/13, 20:49

Commit message

Inside an empty folder is no obvious way to paste the content of the
clipboard.

Add a paste icon to the docheader to paste into the current folder.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Alexander Opitz +1
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Alexander Opitz +1

Issues 1

Files 2

Review log 19

  1. Stefan Neufeind commented on patch set 1 05/21/13, 05:20

    Looks good to me, but someone else must approve
  2. Alexander Opitz commented on patch set 1 05/21/13, 05:20

    It works, but why I need to activate the "clipboard" to show this buttons in filelist? In the Listmodule I do not need to activate the "clipboard".
  3. Jigal van Hemert commented on patch set 1 05/21/13, 05:20

    Fails; I would prefer that you didn't submit this Without the clipboard active the paste-into icons appear with folders in the list, but this past button only appears with the clipboard active. Removing the check for clipboard makes this work. After pasting the buttons don't disappear. You can't paste in the current folder (copy should probably rename the file with a suffix)
  4. Philipp Gampe commented on patch set 1 05/21/13, 05:20

    AFAIK the code could also go to 4.x, but this is up to RM.
  5. Dmitry Dulepov commented on patch set 2 V 0 05/21/13, 05:20

    by team member; Looks good to me, but someone else must approve

    FileList.php:244

    I prefer TRUE in the second argument of getLL. It is a boolean by definition...
  6. Markus Klein commented on patch set 2 05/21/13, 05:20

    Looks good to me, but someone else must approve
  7. Alexander Opitz commented on patch set 2 05/21/13, 05:20

    Verified; Looks good to me, but someone else must approve
  8. Philipp Gampe commented on patch set 2 05/21/13, 05:20

    @Jigal this patch is just about the button, the behavior needs to be fixed elsewhere Content needs to stay in clipboard if you select copy, if you select cut, then the content is removed after paste. I removed the condition for an active clipboard.
  9. Philipp Gampe uploaded patch set 2 05/21/13, 05:20

  10. Markus Klein commented on patch set 3 05/21/13, 05:20

    Looks good to me, but someone else must approve
  11. Alexander Opitz commented on patch set 3 05/21/13, 05:20

    Verified; Looks good to me, but someone else must approve
  12. Philipp Gampe commented on patch set 3 05/21/13, 05:20

    Took care of Dmitrys comment.
  13. Philipp Gampe uploaded patch set 3 05/21/13, 05:20

  14. Mr. Jenkins commented on patch set 1 05/21/13, 05:20

  15. Mr. Jenkins commented on patch set 2 05/21/13, 05:20

  16. Mr. Jenkins commented on patch set 3 05/21/13, 05:20

  17. Wouter Wolters commented on patch set 3 V 0 05/21/13, 05:20

    by team member; Looks good to me, approved Keeping Dmitry his vote as valid I merge this now.
  18. Wouter Wolters merged patch set 4 05/21/13, 05:20

  19. Felix Kopp commented on patch set 4 05/21/13, 05:20

    Fyi: This patch concerns Filelist not page tree folders