Review main Merged

2086[BUGFIX] Flexform sheet description should be editable via TSConfig

Kai Richter CR +2 V +2 Easy +21 −4 updated 06/03/13, 20:49

Commit message

Flexform sheet description, short description and language meta settings are now editable via TSConfig.

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Stefan Neufeind +1
  • Verified V +2
    • Andreas Wolf +2
    • Stefan Neufeind +1

Issues 1

Files 1

Review log 18

  1. Andreas Wolf merged patch set 1 06/23/11, 21:09

  2. Steffen Gebert uploaded patch set 2 06/23/11, 21:09

  3. Steffen Gebert uploaded patch set 3 06/23/11, 21:09

  4. Steffen Gebert commented on patch set 3 06/23/11, 21:09

    I would prefer that you didn't submit this accidently pushed patch for 4-5 to master branch
  5. Andreas Wolf commented on patch set 4 1 comment 06/23/11, 21:09

    Looks good to me, but someone else must approve Apart from my one comment (which I'm pretty sure does not apply) the patch looks fine. Had no possibility to verify it though, but will do that later on. @Kai: Do we need additional documentation for that? Or is it just a bugfix for functionality you would expect nevertheless?
  6. Andreas Wolf commented on patch set 4 V 0 06/23/11, 21:09

    by team member; Looks good to me, approved Pushing after my review.
  7. Francois Suter commented on patch set 4 06/23/11, 21:09

  8. Francois Suter commented on patch set 4 06/23/11, 21:09

    Documentation is still missing.
  9. Stefan Neufeind commented on patch set 4 06/23/11, 21:09

    Verified; Looks good to me, but someone else must approve
  10. Steffen Gebert uploaded patch set 4 06/23/11, 21:09

  11. Philipp Gampe commented on patch set 1 06/23/11, 21:09

    (1 inline comment) Isn't this a feature?
    FEATURE ?
  12. Kai Richter commented on patch set 1 06/23/11, 21:09

    (1 inline comment)

    Reply

    Not really, because I have forgotten it while implementing the "Editable Flexforms" feature. So for me it's a bug :-)

    class.t3lib_tceforms_flexforms.php:125 Reply

    Yes it will break title changes, but now it's correct and prevents problems with a field named "title". I'll change this in existing documentation. The language handling and sheet descriptions are undocumented yet.
  13. Kai Richter commented on patch set 4 06/23/11, 21:09

    (1 inline comment)
  14. Mr. Jenkins commented on patch set 1 06/23/11, 21:09

  15. Mr. Jenkins commented on patch set 2 06/23/11, 21:09

  16. Mr. Jenkins commented on patch set 3 06/23/11, 21:09

    Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/519/ : FAILURE
  17. Mr. Jenkins commented on patch set 4 06/23/11, 21:09