Review main Merged

20860[FEATURE] Scheduler: Add delete button to edit view

Philipp Gampe CR +2 V +2 Easy +7 −1 updated 06/22/13, 22:36

Commit message

The task edit view misses a delete button similar to the tceforms edit
view.
Add this button for the edit action.

Group the buttons to distinguish close from save and save from delete.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 2

Review log 11

  1. Stephan Großberndt commented on patch set 1 05/27/13, 17:19

    Looks good to me, but someone else must approve Thanks for adding the feature. I would verify it, but I do not have any 6.x installations available. Could you backport it to 4.7? In the commit message it should read similar, not simular :-)
  2. Stefan Neufeind commented on patch set 1 05/27/13, 17:19

    Looks good to me, but someone else must approve
  3. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  4. Wouter Wolters commented on patch set 1 05/27/13, 17:19

    I would prefer that you didn't submit this will push an update later
    buttom -> button
  5. Philipp Gampe updated the commit message in patch set 1 06/15/13, 12:06

  6. Philipp Gampe commented on patch set 1 06/15/13, 12:06

    Reply

    Done
  7. Wouter Wolters voted on patch set 2 V +1 CR +1 06/15/13, 12:12

  8. Wouter Wolters uploaded patch set 3 06/15/13, 12:30

  9. Wouter Wolters voted on patch set 3 V +1 CR +1 06/15/13, 12:30

  10. Christian Kuhn voted on patch set 3 V +2 CR +2 06/22/13, 22:36

  11. Christian Kuhn merged patch set 4 06/22/13, 22:36