20875[BUGFIX] uploading extname_1.0.3 (1).zip creates extension "extname (1)"
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Dmitry Dulepov +2
- Alexander Opitz +1
-
Verified V +2
- Wouter Wolters +2
- Dmitry Dulepov +2
Issues 1
Files 2
Review log 13
-
Philipp Gampe uploaded patch set 2 05/26/13, 17:32
-
Mr. Jenkins commented on patch set 1 05/26/13, 17:32
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8807/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/26/13, 17:32
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8808/ : SUCCESS -
Wouter Wolters uploaded patch set 3 05/26/13, 17:32
-
Dmitry Dulepov commented on patch set 4 V 0 05/26/13, 17:32
by team member; Looks good to me, approved -
Alexander Opitz commented on patch set 4 05/26/13, 17:32
(1 inline comment)UploadExtensionFileController.php:161Isn't it easier to substr to the first occurrence of an underscore from the strtolower($fileName)? -
Alexander Opitz commented on patch set 4 1 comment 05/26/13, 17:32
Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 4 05/26/13, 17:32
(1 inline comment) -
Mr. Jenkins commented on patch set 4 05/26/13, 17:32
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8814/ : SUCCESS -
Wouter Wolters uploaded patch set 4 05/26/13, 17:32
-
Wouter Wolters commented on patch set 4 05/26/13, 17:32
Verified; Looks good to me, but someone else must approve Added one more test. Windows is putting the extra parts without a space. -
Wouter Wolters commented on patch set 4 V 0 05/26/13, 17:32
by team member; Looks good to me, approved -
Wouter Wolters merged patch set 5 05/26/13, 17:32
UploadExtensionFileController.php:161Reply