Review main Merged

20884[BUGFIX] Wrong placement of image caption in text with image

Philipp Gampe CR +2 V +2 Easy +4 −7 updated 06/29/13, 12:40

Commit message

If you omit the first caption, then the following captions are shifted
into this position, meaning the the captions are off by the number of
empty captions in front.

This happens because the captions are stored with a newline "\n" as
separator which is removed by a trim = 1.

Remove this trim from tt_content.image.20.caption.1.1 as the trimming of
the actual content happens with
tt_content.image.20.caption.1.stdWrap.trim = 1.

The change also has a few cleanups that popped up in PhpStorm while
investigation the issue.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Wouter Wolters +1
  • Verified V +2
    • Stefan Neufeind +2
    • Wouter Wolters +1

Issues 1

Files 4

Review log 7

  1. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  2. Philipp Gampe commented on patch set 1 06/15/13, 11:53

    Push ... easy to reproduce.
  3. Philipp Gampe uploaded patch set 2 06/15/13, 12:25

  4. Philipp Gampe commented on patch set 2 06/15/13, 12:26

    the behavior needs to be changed in all files
  5. Wouter Wolters voted on patch set 2 V +1 CR +1 06/15/13, 12:26

  6. Stefan Neufeind voted on patch set 2 V +2 CR +2 06/29/13, 12:40

  7. Stefan Neufeind merged patch set 3 06/29/13, 12:40