Review main Merged

20901[BUGFIX] Page-TSconfig ###PAGE_TSCONFIG_STR### not evaluated correctly

Wouter Wolters CR +2 V +2 Easy +2 −2 updated 07/06/14, 13:29

Commit message

Page-TSconfig ###PAGE_TSCONFIG_STR### not evaluated
correctly in the backend.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2

Issues 1

Files 1

Review log 14

  1. Oliver Hader commented on patch set 1 05/27/13, 17:19

    I would prefer that you didn't submit this Too specific. Have a look what the $bParams array contains: $this->renderRecord_flexProc_procInData($currentValueArray['data'], $dataStructArray, array($data, $fieldConfig, $TSconfig, $table, $row, $field) Instead of "pi_flexform" the accordant $field value needs to be used here - otherwise e.g. "TCEFORM.tx_myext_table.my_custom_flexform.PAGE_TSCONFIG_ID" won't work.
  2. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  3. Wouter Wolters commented on patch set 1 05/27/13, 17:19

    Thanks for the hint Oliver. I pushed this patch to get things going. I stumbled upon this one in Forge... Will have a look at it soon.
  4. Wouter Wolters uploaded patch set 2 06/19/14, 15:31

  5. Mr. Jenkins commented on patch set 2 06/19/14, 15:47

  6. Susi Moog commented on patch set 2 V +1 CR +1 06/19/14, 16:54

    Attached test extension to forge issue. Installed it and tried to add a record with a flexform - on the third tab you can select items (after setting pid in TCEFORM.tx_foobar_domain_model_foobarbazza.foo.PAGE_TSCONFIG_STR = 33) but not save them - until after you add the patch.
  7. Wouter Wolters commented on patch set 2 06/20/14, 10:11

  8. Claus Due voted on patch set 2 CR +1 06/20/14, 10:38

  9. Wouter Wolters commented on patch set 2 V +1 CR +1 07/01/14, 22:27

    I only pushed the code from Forge, tested with the given example extension.
  10. Markus Klein uploaded patch set 3 07/06/14, 13:15

  11. Markus Klein commented on patch set 3 V +2 CR +2 07/06/14, 13:16

    rebased, updated a comment. votes still valid.
  12. Markus Klein merged patch set 4 07/06/14, 13:16

  13. Markus Klein commented on patch set 4 07/06/14, 13:16

    Cherry Picked This patchset was cherry picked to change: Ieda08a1df71117b5ac90f2c68260f5171570ff63
  14. Mr. Jenkins commented on patch set 3 07/06/14, 13:29