20902[BUGFIX] CSV-Download not working in IE and HTTPS backend
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Markus Klein +1
-
Verified V +2
- Christian Kuhn +2
- Markus Klein +1
Issues 1
Files 1
Review log 15
-
Philipp Gampe commented on patch set 1 05/27/13, 17:19
(1 inline comment) I would prefer a bit more description about this IE bug.DatabaseRecordList.php:1537why pragma cache? shouldn't this be nocache? Can we omit the pragma header? according to http://stackoverflow.com/questions/6573524/ie-not-downloading-files-over-ssl Cache-Control: private should do the job, can you test this? -
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8827/ : SUCCESS -
Wouter Wolters uploaded patch set 2 06/11/13, 20:06
-
Mr. Jenkins commented on patch set 2 06/11/13, 20:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9039/ : SUCCESS -
Wouter Wolters updated the commit message in patch set 2 06/11/13, 20:07
-
Mr. Jenkins commented on patch set 3 06/11/13, 20:08
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9040/ : SUCCESS -
Stefan Neufeind commented on patch set 3 CR -1 07/30/13, 23:05
But we don't want the result cached. Accoring to the php-docs for function header() the problem are no-store and no-cache. Can we maybe send some other header for a similar result? Like "Cache-Control: private" or so? Should we use the workaround only in case https was used for the request maybe? -
Stefan Neufeind commented on patch set 3 01/24/14, 00:12
Wouter? Could you take a short look at the comment please, which I gave "back then"? -
Wouter Wolters commented on patch set 3 02/05/14, 16:31
This solution is also used in https://review.typo3.org/#/c/27217/ so please continue this one as is. -
Markus Klein commented on patch set 3 V +1 CR +1 02/05/14, 17:41
v+1 without actually testing, just to keep occurrences in core in sync. If we want to change things with caching here, I'd suggest to use another patch then. -
Stefan Neufeind commented on patch set 3 CR 0 02/06/14, 08:07
unblocking -
Christian Kuhn voted on patch set 3 V +2 CR +2 02/08/14, 18:34
-
Christian Kuhn merged patch set 4 02/08/14, 18:34
-
Christian Kuhn commented on patch set 4 02/08/14, 18:35
Cherry Picked This patchset was cherry picked to change: Iefa63fb37d57491fb73bfd504b6caed5b76c8cac -
Christian Kuhn commented on patch set 4 02/08/14, 18:36
Cherry Picked This patchset was cherry picked to change: Iefa63fb37d57491fb73bfd504b6caed5b76c8cac