Review main Merged

20902[BUGFIX] CSV-Download not working in IE and HTTPS backend

Wouter Wolters CR +2 V +2 Easy +4 −2 updated 02/08/14, 18:36

Commit message

When using a HTTPS backend the download of CSV is not
working in Internet Explorer browser versions lower then 9.
Add the needed header to fix this problem.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Markus Klein +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Klein +1

Issues 1

Files 1

Review log 15

  1. Philipp Gampe commented on patch set 1 05/27/13, 17:19

    (1 inline comment) I would prefer a bit more description about this IE bug.

    DatabaseRecordList.php:1537

    why pragma cache? shouldn't this be nocache? Can we omit the pragma header? according to http://stackoverflow.com/questions/6573524/ie-not-downloading-files-over-ssl Cache-Control: private should do the job, can you test this?
  2. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  3. Wouter Wolters uploaded patch set 2 06/11/13, 20:06

  4. Mr. Jenkins commented on patch set 2 06/11/13, 20:07

  5. Wouter Wolters updated the commit message in patch set 2 06/11/13, 20:07

  6. Mr. Jenkins commented on patch set 3 06/11/13, 20:08

  7. Stefan Neufeind commented on patch set 3 CR -1 07/30/13, 23:05

    But we don't want the result cached. Accoring to the php-docs for function header() the problem are no-store and no-cache. Can we maybe send some other header for a similar result? Like "Cache-Control: private" or so? Should we use the workaround only in case https was used for the request maybe?
  8. Stefan Neufeind commented on patch set 3 01/24/14, 00:12

    Wouter? Could you take a short look at the comment please, which I gave "back then"?
  9. Wouter Wolters commented on patch set 3 02/05/14, 16:31

    This solution is also used in https://review.typo3.org/#/c/27217/ so please continue this one as is.
  10. Markus Klein commented on patch set 3 V +1 CR +1 02/05/14, 17:41

    v+1 without actually testing, just to keep occurrences in core in sync. If we want to change things with caching here, I'd suggest to use another patch then.
  11. Stefan Neufeind commented on patch set 3 CR 0 02/06/14, 08:07

    unblocking
  12. Christian Kuhn voted on patch set 3 V +2 CR +2 02/08/14, 18:34

  13. Christian Kuhn merged patch set 4 02/08/14, 18:34

  14. Christian Kuhn commented on patch set 4 02/08/14, 18:35

    Cherry Picked This patchset was cherry picked to change: Iefa63fb37d57491fb73bfd504b6caed5b76c8cac
  15. Christian Kuhn commented on patch set 4 02/08/14, 18:36

    Cherry Picked This patchset was cherry picked to change: Iefa63fb37d57491fb73bfd504b6caed5b76c8cac