Review TYPO3_6-1 Merged

20905[BUGFIX] MailUtility::parseAddresses() returns @localhost on empty string

Philipp Gampe CR +2 V +2 Easy +38 −0 updated 06/03/13, 20:49

Commit message

parseAddresses should return an array of email addresses ready to be
feed into swiftmailer.
If an empty string is passed to the function, then it returns
"@localhost", which is not a valid email.
Swiftmailer will throw an exception "Address in mailbox given
[@localhost] does not comply with RFC 2822, 3.6.2."
This happens in ContentObjectRenderer->sendNotifyEmail() which is in
turn used by the frontend login forgotten passwort form.

Skip any addresses without a mailbox given.

Review

  • Code review CR +2
    • Philipp Gampe +2
  • Verified V +2
    • Philipp Gampe +2

Issues 1

Files 2

Review log 2

  1. Philipp Gampe commented on patch set 1 V 0 05/19/13, 09:37

    by team member; Looks good to me, approved direct cherry-pick
  2. Philipp Gampe merged patch set 2 05/19/13, 09:37