Review main Merged

20939[BUGFIX] Don't override the class on the Form elementWrap

Marc Neuhaus CR +2 V +2 Easy +6 −1 updated 12/13/14, 19:53

Commit message

This Changeset fixes an issue, which made it impossible
to give the layout.elementWrap a class attribute, because it
is was simple overridden.
Now it checks if a class is set and appends the default csc-form-*
classes instead of overriding it.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 13

  1. Marc Neuhaus commented on patch set 1 05/27/13, 17:19

    Verified; Looks good to me, but someone else must approve
  2. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  3. Wouter Wolters uploaded patch set 2 07/29/13, 13:18

  4. Wouter Wolters voted on patch set 2 CR +1 07/29/13, 13:18

  5. Mr. Jenkins commented on patch set 2 07/29/13, 13:18

  6. Anja Leichsenring voted on patch set 2 CR +1 V +1 12/13/14, 16:04

  7. Anja Leichsenring uploaded patch set 3 12/13/14, 18:09

  8. Anja Leichsenring commented on patch set 3 CR +1 V +1 12/13/14, 18:10

    sorry, wrong dependency caused this new patchset.
  9. Christian Kuhn updated the commit message in patch set 4 12/13/14, 19:51

  10. Christian Kuhn voted on patch set 4 CR +1 V +1 12/13/14, 19:52

  11. Anja Leichsenring voted on patch set 4 CR +2 V +2 12/13/14, 19:53

  12. Anja Leichsenring merged patch set 4 12/13/14, 19:53

  13. Anja Leichsenring commented on patch set 5 12/13/14, 19:53

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit a884a8d13f4ba36bc67252b0215e809176c6ae14