Review main Merged

2094[BUG] Constant TYPO3_URL_DONATE defined twice

Xavier Perseguers CR +2 V +2 Easy +0 −1 updated 06/03/13, 20:49

Commit message

Constant TYPO3_URL_DONATE is defined twice. Once with
the old, simulate static URL, and once with the new, current
URL.

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Markus Klein +1
    • Philipp Gampe +1
  • Verified V +2
    • Xavier Perseguers +2
    • Markus Klein +1
    • Philipp Gampe +1

Issues 1

Files 1

Review log 13

  1. Xavier Perseguers uploaded patch set 2 05/12/11, 21:26

  2. Markus Klein commented on patch set 3 05/12/11, 21:26

    Verified; Looks good to me, but someone else must approve
  3. Xavier Perseguers commented on patch set 3 V 0 05/12/11, 21:26

    by team member; Looks good to me, approved
  4. Stefano Kowalke uploaded patch set 3 05/12/11, 21:26

  5. Philipp Gampe commented on patch set 3 05/12/11, 21:26

    Verified; Looks good to me, but someone else must approve
  6. Mr. Jenkins commented on patch set 1 05/12/11, 21:26

  7. Mr. Jenkins commented on patch set 1 05/12/11, 21:26

  8. Mr. Jenkins commented on patch set 1 05/12/11, 21:26

    Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/486/ : FAILURE
  9. Mr. Jenkins commented on patch set 2 05/12/11, 21:26

    Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/487/ : FAILURE
  10. Mr. Jenkins commented on patch set 2 05/12/11, 21:26

  11. Mr. Jenkins commented on patch set 3 05/12/11, 21:26

    No score; No score Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/492/ : SUCCESS
  12. Mr. Jenkins commented on patch set 3 05/12/11, 21:26

    Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/491/ : FAILURE
  13. Xavier Perseguers merged patch set 3 05/12/11, 21:26