Review main Merged

20981[BUGFIX] mounts of same storage had same subfolder count in Filelist

Simon Schick CR +2 V +2 Easy +1 −1 updated 09/05/13, 16:36

Commit message

When you opened the filelist module as user who just was allowed to see
a bunch of filemounts, the filemounts had either all or none the expand-
icon, based on the first file-mount of this storage the user has access
to.

Review

  • Code review CR +2
    • Stefan Neufeind +2
  • Verified V +2
    • Stefan Neufeind +2

Issues 1

Files 1

Review log 15

  1. Simon Schick uploaded patch set 2 05/27/13, 17:19

  2. Marc Bastian Heinrichs commented on patch set 3 05/27/13, 17:19

    Verified; Looks good to me, but someone else must approve
  3. Simon Schick uploaded patch set 3 05/27/13, 17:19

  4. Simon Schick commented on patch set 3 05/27/13, 17:19

    Verified; Looks good to me, but someone else must approve I use this solution in production for a client ...
  5. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/8859/ : FAILURE
  6. Mr. Jenkins commented on patch set 2 05/27/13, 17:19

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/8860/ : FAILURE
  7. Mr. Jenkins commented on patch set 3 05/27/13, 17:19

  8. Gerrit wrote 09/05/13, 16:34

    The change could not be merged due to a path conflict. Please rebase the change locally and upload the rebased commit for review.
  9. Stefan Neufeind voted on patch set 3 V +2 CR +2 09/05/13, 16:34

  10. Stefan Neufeind uploaded patch set 4 09/05/13, 16:35

  11. Stefan Neufeind commented on patch set 4 V +2 CR +2 09/05/13, 16:36

    just locally rebased. Tried and works fine for me.
  12. Stefan Neufeind merged patch set 5 09/05/13, 16:36

  13. Stefan Neufeind commented on patch set 5 09/05/13, 16:36

    Cherry Picked This patchset was cherry picked to change: I1e6a29e351a643f52c0f7a42fde38c9d9b2fc5cb
  14. Mr. Jenkins commented on patch set 4 09/05/13, 16:36

  15. Stefan Neufeind commented on patch set 5 09/05/13, 16:36

    Cherry Picked This patchset was cherry picked to change: I1e6a29e351a643f52c0f7a42fde38c9d9b2fc5cb