Review main Merged

20992[FEATURE] Improve livesearch results

anonymized-50850 CR +2 V +2 Easy +3 −2 updated 06/03/13, 20:49

Commit message

* uid and pid are displayed as tooltip in livesearch results
* returnUrl set so closing edit mask won't lead to dummy.php

Review

  • Code review CR +2
    • Wouter Wolters +2
  • Verified V +2
    • Wouter Wolters +2

Issues 1

Files 1

Review log 13

  1. Alexander Opitz commented on patch set 1 05/25/13, 11:47

    (2 inline comments) Sounds good, 2 hints given.
    Resolves: #35358

    LiveSearch.php:262

    The list module may be disabled for the user.
  2. Mattias Nilsson commented on patch set 1 05/25/13, 11:47

    Verified; Looks good to me, but someone else must approve
  3. Alexander Opitz commented on patch set 2 05/25/13, 11:47

    Looks good to me, but someone else must approve Ok, also didn't know that. :-)
  4. Mattias Nilsson commented on patch set 2 05/25/13, 11:47

    Verified; Looks good to me, but someone else must approve
  5. anonymized-50850 commented on patch set 2 05/25/13, 11:47

    Only modified the commit message. Regarding the other comment: the livesearch box is only available when the list module is available. Didn't know that either, just tried it...
  6. anonymized-50850 uploaded patch set 2 05/25/13, 11:47

  7. Mr. Jenkins commented on patch set 1 05/25/13, 11:47

  8. Mr. Jenkins commented on patch set 2 05/25/13, 11:47

  9. Wouter Wolters commented on patch set 2 V 0 05/25/13, 11:47

    by team member; I would prefer that you didn't submit this Pushing an update in a sec, one small CGL change
  10. Mr. Jenkins commented on patch set 3 05/25/13, 11:47

  11. Wouter Wolters uploaded patch set 3 05/25/13, 11:47

  12. Wouter Wolters commented on patch set 3 V 0 05/25/13, 11:47

    by team member; Looks good to me, approved Keeping previous votes as valid, only one small CGL change applied in latest set I merge this small but useful FEATURE now.
  13. Wouter Wolters merged patch set 4 05/25/13, 11:47