20992[FEATURE] Improve livesearch results
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
-
Verified V +2
- Wouter Wolters +2
Issues 1
Files 1
Review log 13
-
Alexander Opitz commented on patch set 1 05/25/13, 11:47
(2 inline comments) Sounds good, 2 hints given.Resolves: #35358LiveSearch.php:262The list module may be disabled for the user. -
Mattias Nilsson commented on patch set 1 05/25/13, 11:47
Verified; Looks good to me, but someone else must approve -
Alexander Opitz commented on patch set 2 05/25/13, 11:47
Looks good to me, but someone else must approve Ok, also didn't know that. :-) -
Mattias Nilsson commented on patch set 2 05/25/13, 11:47
Verified; Looks good to me, but someone else must approve -
anonymized-50850 commented on patch set 2 05/25/13, 11:47
Only modified the commit message. Regarding the other comment: the livesearch box is only available when the list module is available. Didn't know that either, just tried it... -
anonymized-50850 uploaded patch set 2 05/25/13, 11:47
-
Mr. Jenkins commented on patch set 1 05/25/13, 11:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8867/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/25/13, 11:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8870/ : SUCCESS -
Wouter Wolters commented on patch set 2 V 0 05/25/13, 11:47
by team member; I would prefer that you didn't submit this Pushing an update in a sec, one small CGL change -
Mr. Jenkins commented on patch set 3 05/25/13, 11:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8877/ : SUCCESS -
Wouter Wolters uploaded patch set 3 05/25/13, 11:47
-
Wouter Wolters commented on patch set 3 V 0 05/25/13, 11:47
by team member; Looks good to me, approved Keeping previous votes as valid, only one small CGL change applied in latest set I merge this small but useful FEATURE now. -
Wouter Wolters merged patch set 4 05/25/13, 11:47