Review main Merged

21096[BUGFIX] Add table as parameter to CObjectViewHelper

Wouter Wolters CR +2 V +2 Easy +3 −2 updated 10/08/13, 23:33

Commit message

When passing a tt_content record with an image to the
CObjectViewHelper it doesn't convert the FAL reference with
an image path. To correct this we add an optional parameter
for the table.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Helmut Hummel +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1

Issues 1

Files 1

Review log 7

  1. Anja Leichsenring commented on patch set 1 CR -1 06/24/13, 19:55

    I can't find a bug thats solved by the patch, will ask the reporter.
  2. Wouter Wolters commented on patch set 1 08/09/13, 19:12

    Anja, the reporter has responded in the ticket. Can you have a look?
  3. Anja Leichsenring commented on patch set 1 V +1 CR +1 10/06/13, 13:38

    lets put it in.
  4. Christian Kuhn commented on patch set 1 10/06/13, 20:20

    I think helmut should have a look at this one.
  5. Helmut Hummel commented on patch set 1 CR +1 10/07/13, 01:25

    It makes sense to extend the view helper, although there is still a problem with the FAL "API"
  6. Christian Kuhn voted on patch set 1 V +2 CR +2 10/08/13, 23:33

  7. Christian Kuhn merged patch set 2 10/08/13, 23:33