Review main Merged

21101[BUGFIX] IdentityProperties were not set

Wouter Wolters CR +2 V +2 Easy +1 −0 updated 03/04/14, 11:46

Commit message

After submitting an invalid form twice, extbase tries to
create the related submodel instead of edit.
This is because of the missing __identity part
for the related submodel

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Stefan Neufeind +1
    • Stefan Froemken +1
  • Verified V +2
    • Anja Leichsenring +2
    • Stefan Froemken +1

Issues 1

Files 1

Review log 12

  1. Stefan Neufeind voted on patch set 1 CR +1 07/30/13, 23:07

  2. Marc Bastian Heinrichs wrote 10/21/13, 18:21

    Topic set to "fluid".
  3. Anja Leichsenring uploaded patch set 2 03/02/14, 09:46

  4. Anja Leichsenring commented on patch set 2 V +1 CR +1 03/02/14, 09:49

    there had been a typo leading to the usage of a non existing function.
  5. Mr. Jenkins commented on patch set 2 03/02/14, 09:59

  6. Stefan Neufeind voted on patch set 2 CR +1 03/03/14, 22:58

  7. Stefan Froemken commented on patch set 2 V +1 CR +1 03/04/14, 08:29

    Tested with a little extension specially created for this ticket. Works good.
  8. Anja Leichsenring voted on patch set 2 V +2 CR +2 03/04/14, 08:50

  9. Anja Leichsenring merged patch set 3 03/04/14, 08:50

  10. Marc Bastian Heinrichs commented on patch set 3 03/04/14, 09:46

    Did you checked, if this happen because of a missing security configuration? The rewritten propertymapper doesn't allow editing and creation of related models. You need to explicit allow this in the PropertyMappingConfiguration: http://docs.typo3.org/flow/TYPO3FlowDocumentation/TheDefinitiveGuide/PartIII/PropertyMapping.html#security-considerations
  11. Stefan Froemken commented on patch set 3 03/04/14, 10:00

    Sure. In earlier versions you have to add them on your own. But since XY there is a new method in Field-VHs $this->registerFieldNameForFormTokenGeneration($name); which add the field automatically to form token. So I don't see a security problem here.
  12. Marc Bastian Heinrichs commented on patch set 3 03/04/14, 11:46

    Ok, the security configuration is not the problem. It gets created correct by __trustedProperties. But this fix should be checked by the Flow team and needs a upstream issue and fix.