Review TYPO3_4-7 Abandoned

21109[BUGFIX] Calculate percentage of differences if column is shown

Helmut Hummel CR 0 V 0 Normal +157 −5 updated 07/05/13, 12:23

Commit message

The workspace view in the backend has a feature to calculate
the percentage of differences between live and workspace
version. This implementation iterates over each record and each
field by using the PHP method similar_text(). The complexity of
similar_text() is measured with O(n^3) which quickly can turn
into a nice waiting period if string length is more than approx
4000 characters.

This feature has been removed completely in TYPO3 6.0.

Review

  • Code review CR 0
  • Verified V 0

Files 3

Review log 3

  1. Helmut Hummel commented on patch set 1 05/27/13, 20:35

    I would prefer that you didn't submit this This may be obsolete
  2. Stefan Neufeind commented on patch set 1 05/28/13, 10:59

    Olli, over at https://review.typo3.org/#/c/13614/ I mentioned that I think this is obsolete. Could you please clarify?
  3. Steffen Ritter abandoned the change 07/05/13, 12:23

    Only security sixes for TYPO3 4.7 since May 2013