Review main Merged

21112[FEATURE] Transfer query parameters in preview

Helmut Hummel CR +2 V +2 Easy +10 −4 updated 10/06/13, 20:46

Commit message

The workspace preview does not transfer query parameters to the
iframes used for preview. This prevents extensions passing custom
parameters from functioning properly.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Sascha Egerer +1
  • Verified V +2
    • Christian Kuhn +2
    • Sascha Egerer +1

Issues 1

Files 1

Review log 5

  1. Sascha Egerer uploaded patch set 2 10/05/13, 13:49

  2. Sascha Egerer commented on patch set 2 V +1 CR +1 10/05/13, 13:50

    I've changed it to a "FEATURE" and only for 6.2 (due to feature status). Also rebased it to the current master
  3. Mr. Jenkins commented on patch set 2 10/05/13, 14:01

  4. Christian Kuhn voted on patch set 2 V +2 CR +2 10/06/13, 20:46

  5. Christian Kuhn merged patch set 3 10/06/13, 20:46