Review main Merged

21120[BUGFIX] foreign_match_fields not fully supported

Wouter Wolters CR +2 V +2 Easy +18 −2 updated 01/08/14, 16:55

Commit message

foreign_match_fields were not fully supported
Resolves: #47694
Relates: #45337
Releases: 6.2, 6.1
Change-Id: I212cbdb5d4a3791c1d8ed1e431007e10dd9f11e8
Reviewed-on: https://review.typo3.org/21120
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Frans Saris +1
  • Verified V +2
    • Stefan Neufeind +2
    • Frans Saris +1

Files 1

Review log 16

  1. Mr. Jenkins commented on patch set 1 05/27/13, 20:54

  2. Stefan Neufeind commented on patch set 1 05/28/13, 11:00

    Looks good to me, but someone else must approve regiving vote from https://review.typo3.org/#/c/20297/ without another review
  3. Stefan Froemken uploaded patch set 2 10/07/13, 11:16

  4. Stefan Froemken uploaded patch set 3 10/07/13, 11:26

  5. Mr. Jenkins commented on patch set 2 10/07/13, 11:27

  6. Mr. Jenkins commented on patch set 3 10/07/13, 11:38

  7. Stefan Froemken uploaded patch set 4 10/07/13, 13:27

  8. Mr. Jenkins commented on patch set 4 10/07/13, 13:43

  9. Wouter Wolters wrote 10/16/13, 18:18

    Topic set to "extbase".
  10. Frans Saris commented on patch set 4 V +1 CR +1 11/14/13, 20:47

    I'm working on implementing FAL functionality in ext:News and when trying to save a FileReference this is currently one of the missing thing in persisting the FileReference object.
  11. Stefan Neufeind commented on patch set 4 V +2 CR +2 11/14/13, 21:13

    think I got it ...
  12. Stefan Neufeind merged patch set 5 11/14/13, 21:13

  13. Stefan Neufeind commented on patch set 5 11/14/13, 21:13

    Cherry Picked This patchset was cherry picked to change: I212cbdb5d4a3791c1d8ed1e431007e10dd9f11e8
  14. Marc Bastian Heinrichs commented on patch set 5 01/08/14, 16:02

    Don't the RelationTableMatchFields also needs to be cleared on detachObjectFromParentObject?
  15. Marc Bastian Heinrichs commented on patch set 5 01/08/14, 16:42

    See inline

    Backend.php:366

    I don't get why this is needed. Inline is oneToMany, so the fix in attachObjectToParentObjectRelationHasMany should be enough.
  16. Marc Bastian Heinrichs commented on patch set 5 01/08/14, 16:55

    Backend.php:366 Reply

    Ok, got it. Relevant von oneToOne