Review main Merged

21131[BUGFIX] Filelist: Only show paste buttons if clipObj is set

Philipp Gampe CR +2 V +2 Easy +14 −4 updated 06/19/13, 19:51

Commit message

During introduction of the paste buttons for empty folders, I assumed
that the clipboard object is always set.
This might not be the case, e.g. in EXT:sphinx 4.0.0.

Wrap the paste button code with a check if the clibObj is set.

We can not set the clibObj here, because it depends on variables of the
calling class.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Alexander Opitz +1
  • Verified V +2
    • Christian Kuhn +2
    • Alexander Opitz +1

Issues 1

Files 2

Review log 10

  1. Mr. Jenkins commented on patch set 1 05/28/13, 13:18

  2. Wouter Wolters voted on patch set 1 CR +1 06/04/13, 18:42

  3. Philipp Gampe commented on patch set 1 06/15/13, 11:41

    push
  4. Alexander Opitz commented on patch set 1 V +1 CR +1 06/17/13, 08:27

    assemumed => assumed
  5. Philipp Gampe updated the commit message in patch set 1 06/18/13, 23:24

  6. Philipp Gampe commented on patch set 2 06/18/13, 23:25

    I just changed the commit message. Note: Since last gerrit update, you can edit the commit message directly on the top-right corner.
  7. Mr. Jenkins commented on patch set 2 06/18/13, 23:25

  8. Alexander Opitz voted on patch set 2 V +1 CR +1 06/19/13, 07:05

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 06/19/13, 19:51

  10. Christian Kuhn merged patch set 3 06/19/13, 19:51