2114[TASK] Remove override of authentication fields
Commit message
Review
-
Code review CR +2
- Xavier Perseguers +2
- Stefan Neufeind +1
- Georg Ringer +1
- Oliver Klee +1
- Dmitry Dulepov +1
-
Verified V +2
- Xavier Perseguers +2
Issues 1
Files 1
Review log 11
-
Björn Pedersen commented on patch set 1 06/27/11, 06:52
Looks good to me, but someone else must approve -
Oliver Klee commented on patch set 1 06/27/11, 06:52
I would prefer that you didn't submit this Looks generally good. However, could you please fix the following CGL nits? - Please add a comma after the last array element. - Please either completely drop the end-line comments or change them to "above the line"-comments. -
Dmitry Dulepov commented on patch set 2 06/27/11, 06:52
Looks good to me, but someone else must approve I like the idea very much. I also found that the following two attributes are used in t3lib_userauth but not defined there. Instead they are defined in tslib_feuserauth: $usergroup_column = 'usergroup'; var $usergroup_table = 'fe_groups'; Should they be moved to t3lib_userauth? -
Stefan Neufeind commented on patch set 2 06/27/11, 06:52
Looks good to me, but someone else must approve -
Oliver Klee commented on patch set 2 06/27/11, 06:52
Looks good to me, but someone else must approve -
Xavier Perseguers uploaded patch set 2 06/27/11, 06:52
-
Xavier Perseguers commented on patch set 2 V 0 06/27/11, 06:52
by team member; Looks good to me, approved -
Georg Ringer commented on patch set 2 06/27/11, 06:52
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 06/27/11, 06:52
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/497/ : SUCCESS -
Mr. Jenkins commented on patch set 2 06/27/11, 06:52
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/502/ : SUCCESS -
Xavier Perseguers merged patch set 2 06/27/11, 06:52