Review main Merged

2114[TASK] Remove override of authentication fields

Xavier Perseguers CR +2 V +2 Normal +32 −26 updated 06/03/13, 20:49

Commit message

Many class fields in tslib_feUserAuth override the ones from
parent class t3lib_userAuth. This makes refactoring complicated.
Change default value inside a constructor instead.

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Stefan Neufeind +1
    • Georg Ringer +1
    • Oliver Klee +1
    • Dmitry Dulepov +1
  • Verified V +2
    • Xavier Perseguers +2

Issues 1

Files 1

Review log 11

  1. Björn Pedersen commented on patch set 1 06/27/11, 06:52

    Looks good to me, but someone else must approve
  2. Oliver Klee commented on patch set 1 06/27/11, 06:52

    I would prefer that you didn't submit this Looks generally good. However, could you please fix the following CGL nits? - Please add a comma after the last array element. - Please either completely drop the end-line comments or change them to "above the line"-comments.
  3. Dmitry Dulepov commented on patch set 2 06/27/11, 06:52

    Looks good to me, but someone else must approve I like the idea very much. I also found that the following two attributes are used in t3lib_userauth but not defined there. Instead they are defined in tslib_feuserauth: $usergroup_column = 'usergroup'; var $usergroup_table = 'fe_groups'; Should they be moved to t3lib_userauth?
  4. Stefan Neufeind commented on patch set 2 06/27/11, 06:52

    Looks good to me, but someone else must approve
  5. Oliver Klee commented on patch set 2 06/27/11, 06:52

    Looks good to me, but someone else must approve
  6. Xavier Perseguers uploaded patch set 2 06/27/11, 06:52

  7. Xavier Perseguers commented on patch set 2 V 0 06/27/11, 06:52

    by team member; Looks good to me, approved
  8. Georg Ringer commented on patch set 2 06/27/11, 06:52

    Looks good to me, but someone else must approve
  9. Mr. Jenkins commented on patch set 1 06/27/11, 06:52

  10. Mr. Jenkins commented on patch set 2 06/27/11, 06:52

  11. Xavier Perseguers merged patch set 2 06/27/11, 06:52