Review main Merged

21166[TASK] Mark Extbase\Mvc\Controller\FlashMessageContainer deprecated

Alexander Schnitzler CR +2 V +2 Easy +14 −1 updated 10/02/13, 14:00

Commit message

As Extbase uses the new FlashMessageService provided by the core the
old FlashMessageContainer has to be marked deprecated. Therefore also
TYPO3\CMS\Extbase\Mvc\Controller\AbstractController->injectFlash
MessageContainer has to be marked deprecated but must not throw
create a deprecation log entry.

Review

  • Code review CR +2
    • Alexander Schnitzler +2
    • Wouter Wolters +1
  • Verified V +2
    • Alexander Schnitzler +2

Issues 1

Files 2

Review log 9

  1. Mr. Jenkins commented on patch set 1 05/30/13, 10:29

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/8949/ : FAILURE
  2. Alexander Schnitzler uploaded patch set 2 05/30/13, 10:36

  3. Mr. Jenkins commented on patch set 2 05/30/13, 10:37

  4. Felix Kopp commented on patch set 2 05/30/13, 20:21

    Perhaps +DeprecationLog additionally?
  5. Alexander Schnitzler commented on patch set 2 06/01/13, 11:52

    Nope, as Extbase injects the object it must not log a deprecation method. Only if the user uses it should be logged. :)
  6. Wouter Wolters voted on patch set 2 CR +1 06/04/13, 17:21

  7. Alexander Schnitzler commented on patch set 2 V +2 CR +2 06/04/13, 19:35

    Just changed comments, no code.
  8. Alexander Schnitzler merged patch set 3 06/04/13, 19:35

  9. Markus Klein commented on patch set 3 10/02/13, 14:00

    Post -1: You forgot to specify an alternative with the @deprecated annotations and also you didn't create a documentation issue for this change. See now: http://forge.typo3.org/issues/52472