Review main Abandoned

21172[BUGFIX] findObjectByIdentifier in Backend must not respect enable fields

Alexander Schnitzler CR 0 V 0 Easy +1 −0 updated 12/11/14, 22:39

Commit message

With the introduction of enhanced query settings the method
findObjectByIdentifier changed its behaviour as enable fields
are respected by default which is wrong for this method.

The methods functionality is defined by fetching an object by
its identifier which is not marked as deleted. Therefore the
only constraint must be "deleted = 0".

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 14

  1. Mr. Jenkins commented on patch set 1 05/31/13, 09:42

  2. Anja Leichsenring commented on patch set 1 05/31/13, 10:15

    Verified; Looks good to me, but someone else must approve obvious
  3. Marc Bastian Heinrichs commented on patch set 1 05/31/13, 15:32

    I would prefer that you didn't submit this quote: --- With the introduction of enhanced query settings the method findObjectByIdentifier changed its behaviour as enable fields are respected by default which is wrong for this method. --- I don't see the behaviour change. Could you explain this in detail?
  4. Alexander Schnitzler commented on patch set 1 05/31/13, 16:45

    I would prefer that you didn't submit this As discussed I will update this patch.
  5. Alexander Schnitzler uploaded patch set 2 06/28/13, 13:29

  6. Mr. Jenkins commented on patch set 2 06/28/13, 13:30

  7. Mattias Nilsson voted on patch set 2 V +1 CR +1 06/28/13, 13:56

  8. Marc Bastian Heinrichs commented on patch set 2 CR -2 06/29/13, 16:00

    As discussed, the propertymappers PersistentObjectConverter needs to be changed first. It have to use a own query and not persistenceManagers getObjectByIdentifier method. Otherwise e.g. a action for detail view will render also objects which are "protected" by enablefields
  9. Marc Bastian Heinrichs commented on patch set 2 06/29/13, 16:02

    Also this comment is not right. There is no change in the default behaviour.
  10. Alexander Schnitzler commented on patch set 2 CR -2 06/29/13, 16:54

    btw: this was just a rebase. ;)
  11. Anja Leichsenring commented on patch set 2 10/06/13, 08:38

    someone still working on this issue? MaBa? Alex?
  12. Sascha Egerer commented on patch set 2 10/06/13, 10:35

    What about workspaces/versions?
  13. Marc Bastian Heinrichs wrote 10/21/13, 18:31

    Topic updated from "48690" to "extbase".
  14. Alexander Schnitzler abandoned the change 01/13/14, 19:12