Review main Merged

21174[BUGFIX] Fix template rootline for translated pages

Alexander Stehlik CR +2 V +2 Normal +85 −29 updated 06/17/13, 07:04

Commit message

The TypoScript template rootline in the Frontend will not be
changed any more if a different sys_language_uid is used.

The data of the current rootLine will be overwritten with the
translated rootLine data.

Review

  • Code review CR +2
    • Wouter Wolters +2
  • Verified V +2
    • Wouter Wolters +2

Issues 1

Files 4

Review log 13

  1. Mr. Jenkins commented on patch set 1 05/31/13, 15:13

  2. Wouter Wolters commented on patch set 1 V +1 06/04/13, 17:37

    Tested with the Unit-test

    TemplateService.php:726

    timestamp missing as second argument for the exception.
  3. Alexander Stehlik uploaded patch set 2 06/05/13, 08:12

  4. Alexander Stehlik commented on patch set 2 06/05/13, 08:15

    Added Version 6.1 to commit message (not sure if I also should add version 6.0?) and added missing Exception code. Advanced testing instructions can be found in the bug tracker: http://forge.typo3.org/issues/48300
  5. Florian Scholz commented on patch set 2 V +1 CR +1 06/12/13, 09:19

    Works for me, good job!
  6. Stefan Galinski commented on patch set 2 V +1 06/13/13, 17:27

    Indeed a critical bug! The patch seems to work without negative side effects as far as I've seen! Good work! :-)
  7. Stefan Neufeind commented on patch set 2 V +1 CR +1 06/13/13, 23:25

    One easy way to test a corner-case that this patch fixes: * Have a page-tree * Add a root-template on a level other than the tree-root (maybe on level 2 or 3) * In TypoScript output a text-element with ".data = leveltitle : 0" * Try that out with translations Without this patch the leveltitle shown in the translation will be that of the *tree*-root. With this patch the correct title of from the template-rootlevel will be shown (which matches the title shown without translation).

    TemplateService.php:425

    Could be left out (if we might need to push a new revision of the patch). But it doesn't matter.
  8. Stefan Neufeind commented on patch set 2 06/13/13, 23:30

    Same test also possible when using a HMENU with "special=rootline"
  9. Julian Kleinhans voted on patch set 2 V +1 CR +1 06/14/13, 07:39

  10. Wouter Wolters commented on patch set 2 CR -1 06/15/13, 12:37

    Update is on its way.

    TemplateServiceTest.php:58

    $this->fixture is not needed here, probably a copy paste problem:)

    TypoScriptFrontendController.php:2577

    empty line can be removed.
  11. Wouter Wolters uploaded patch set 3 06/15/13, 12:37

  12. Wouter Wolters commented on patch set 3 V +2 CR +2 06/15/13, 12:38

    Only small CGL issues fixed in latest commit. No functional changes. Merging with prevoius votes.
  13. Wouter Wolters merged patch set 4 06/15/13, 12:38