21174[BUGFIX] Fix template rootline for translated pages
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
-
Verified V +2
- Wouter Wolters +2
Issues 1
Files 4
- typo3/sysext/core/Classes/TypoScript/TemplateService.php2+32 −0
- typo3/sysext/core/Tests/Unit/TypoScript/TemplateServiceTest.php1+51 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php1+2 −4
- typo3/sysext/frontend/Tests/Unit/Controller/TypoScriptFrontendControllerTest.php+0 −25
Review log 13
-
Mr. Jenkins commented on patch set 1 05/31/13, 15:13
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8956/ : SUCCESS -
Wouter Wolters commented on patch set 1 V +1 06/04/13, 17:37
Tested with the Unit-testTemplateService.php:726timestamp missing as second argument for the exception. -
Alexander Stehlik uploaded patch set 2 06/05/13, 08:12
-
Alexander Stehlik commented on patch set 2 06/05/13, 08:15
Added Version 6.1 to commit message (not sure if I also should add version 6.0?) and added missing Exception code. Advanced testing instructions can be found in the bug tracker: http://forge.typo3.org/issues/48300 -
Florian Scholz commented on patch set 2 V +1 CR +1 06/12/13, 09:19
Works for me, good job! -
Stefan Galinski commented on patch set 2 V +1 06/13/13, 17:27
Indeed a critical bug! The patch seems to work without negative side effects as far as I've seen! Good work! :-) -
Stefan Neufeind commented on patch set 2 V +1 CR +1 06/13/13, 23:25
One easy way to test a corner-case that this patch fixes: * Have a page-tree * Add a root-template on a level other than the tree-root (maybe on level 2 or 3) * In TypoScript output a text-element with ".data = leveltitle : 0" * Try that out with translations Without this patch the leveltitle shown in the translation will be that of the *tree*-root. With this patch the correct title of from the template-rootlevel will be shown (which matches the title shown without translation).TemplateService.php:425Could be left out (if we might need to push a new revision of the patch). But it doesn't matter. -
Stefan Neufeind commented on patch set 2 06/13/13, 23:30
Same test also possible when using a HMENU with "special=rootline" -
Julian Kleinhans voted on patch set 2 V +1 CR +1 06/14/13, 07:39
-
Wouter Wolters commented on patch set 2 CR -1 06/15/13, 12:37
Update is on its way.TemplateServiceTest.php:58$this->fixture is not needed here, probably a copy paste problem:)TypoScriptFrontendController.php:2577empty line can be removed. -
Wouter Wolters uploaded patch set 3 06/15/13, 12:37
-
Wouter Wolters commented on patch set 3 V +2 CR +2 06/15/13, 12:38
Only small CGL issues fixed in latest commit. No functional changes. Merging with prevoius votes. -
Wouter Wolters merged patch set 4 06/15/13, 12:38