Review main Merged

21181[BUGFIX] FormFieldVH->getPropertyValue() must work without form object

Alexander Schnitzler CR +2 V +2 Easy +3 −0 updated 06/04/13, 19:05

Commit message

Since the new property mapper is active by default it is
possible to create forms without object="{object}", e.g.
using a newAction. This leads to some view helpers throwing
an exception as they rely on a present object to receive the
property value. As this object may not be present a missing
check has to be added to method getPropertyValue().

This check also exists in Flow.Fluid and is necessary to
fix malfunctioning view helpers.

Review

  • Code review CR +2
    • Alexander Schnitzler +2
    • Wouter Wolters +1
  • Verified V +2
    • Alexander Schnitzler +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 11

  1. Mr. Jenkins commented on patch set 1 06/01/13, 08:40

  2. Alexander Schnitzler uploaded patch set 2 06/01/13, 08:41

  3. Mr. Jenkins commented on patch set 2 06/01/13, 08:41

  4. Alexander Schnitzler uploaded patch set 3 06/01/13, 08:50

  5. Mr. Jenkins commented on patch set 3 06/01/13, 08:51

  6. Wouter Wolters commented on patch set 3 V +1 CR -1 06/04/13, 16:41

    A few spelling issues in the commit message. Verified by checking the same code in TYPO3.Fluid
    possibe -> possible
    recieve -> receive
    hast -> has
  7. Alexander Schnitzler uploaded patch set 4 06/04/13, 18:48

  8. Alexander Schnitzler uploaded patch set 5 06/04/13, 18:49

  9. Wouter Wolters voted on patch set 5 V +1 CR +1 06/04/13, 18:51

  10. Alexander Schnitzler voted on patch set 5 V +2 CR +2 06/04/13, 19:05

  11. Alexander Schnitzler merged patch set 6 06/04/13, 19:05