21184[BUGFIX] Enable CheckboxViewHelper binding to ArrayObject and Null
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Wouter Wolters +1
-
Verified V +2
- Anja Leichsenring +2
- Wouter Wolters +1
- Adrian Dymorz +1
Issues 1
Files 2
Review log 7
-
Mr. Jenkins commented on patch set 1 06/01/13, 10:01
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8963/ : SUCCESS -
Adrian Dymorz commented on patch set 1 06/03/13, 06:54
Fails Hi Alexander, thank you for the patch. I tried it, and it solves part of the issue, but the error message mentioned in #48628 still remains. I see that the function get() in ViewHelperVariableContainer is called with the value 'formObject' as $key instead of 'formObjectName', but I did not find out why. Can you please look into this issue once more? Best regards Adrian -
Alexander Schnitzler commented on patch set 1 06/03/13, 20:58
Did you see this patch depends on patch https://review.typo3.org/#/c/21181/3 which has not been merged yet? -
Adrian Dymorz commented on patch set 1 V +1 06/04/13, 08:20
I saw it but I did not realize I had to cherry pick both changes to test. With both changes in place, it works like a charm. The issue mentioned in #48628 is gone. Thank you for solving the issue. -
Wouter Wolters voted on patch set 1 V +1 CR +1 06/04/13, 16:44
-
Anja Leichsenring voted on patch set 1 V +2 CR +2 06/04/13, 19:00
-
Anja Leichsenring merged patch set 2 06/04/13, 19:00