21189[FEATURE] Add ObjectManager->getScope like in TYPO3.Flow
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Wouter Wolters +1
-
Verified V +2
- Anja Leichsenring +2
- Wouter Wolters +1
Issues 1
Files 4
Review log 12
-
Mr. Jenkins commented on patch set 1 06/02/13, 11:03
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8969/ : SUCCESS -
Alexander Schnitzler uploaded patch set 2 06/02/13, 11:06
-
Mr. Jenkins commented on patch set 2 06/02/13, 11:07
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8970/ : SUCCESS -
Alexander Schnitzler uploaded patch set 3 06/02/13, 11:14
-
Mr. Jenkins commented on patch set 3 06/02/13, 11:15
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8971/ : SUCCESS -
Wouter Wolters commented on patch set 3 06/02/13, 18:36
I would prefer that you didn't submit this Update will followObjectManager.php:4use statement is placed below the Copyright notice and above the class comment. -
Wouter Wolters uploaded patch set 4 06/02/13, 18:36
-
Wouter Wolters commented on patch set 4 06/02/13, 18:36
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 4 06/02/13, 18:42
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8982/ : SUCCESS -
Alexander Schnitzler commented on patch set 4 06/03/13, 21:00
What was this 4th patchset for? A rebase? -
Anja Leichsenring voted on patch set 4 V +2 CR +2 06/04/13, 19:33
-
Anja Leichsenring merged patch set 5 06/04/13, 19:33