Review main Merged

21189[FEATURE] Add ObjectManager->getScope like in TYPO3.Flow

Alexander Schnitzler CR +2 V +2 Normal +63 −0 updated 06/04/13, 19:33

Commit message

This method detects if a class is of type prototype or
singleton. We need this method as it is a dependency for
further backporting of the Flow validation api.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
  • Verified V +2
    • Anja Leichsenring +2
    • Wouter Wolters +1

Issues 1

Files 4

Review log 12

  1. Mr. Jenkins commented on patch set 1 06/02/13, 11:03

  2. Alexander Schnitzler uploaded patch set 2 06/02/13, 11:06

  3. Mr. Jenkins commented on patch set 2 06/02/13, 11:07

  4. Alexander Schnitzler uploaded patch set 3 06/02/13, 11:14

  5. Mr. Jenkins commented on patch set 3 06/02/13, 11:15

  6. Wouter Wolters commented on patch set 3 06/02/13, 18:36

    I would prefer that you didn't submit this Update will follow

    ObjectManager.php:4

    use statement is placed below the Copyright notice and above the class comment.
  7. Wouter Wolters uploaded patch set 4 06/02/13, 18:36

  8. Wouter Wolters commented on patch set 4 06/02/13, 18:36

    Verified; Looks good to me, but someone else must approve
  9. Mr. Jenkins commented on patch set 4 06/02/13, 18:42

  10. Alexander Schnitzler commented on patch set 4 06/03/13, 21:00

    What was this 4th patchset for? A rebase?
  11. Anja Leichsenring voted on patch set 4 V +2 CR +2 06/04/13, 19:33

  12. Anja Leichsenring merged patch set 5 06/04/13, 19:33