Review main Merged

21190[TASK] Make preperations for backporting Flow validation api

Alexander Schnitzler CR +2 V +2 Hard +346 −95 updated 06/04/13, 19:46

Commit message

Synced some parts of Extbase validation with the one of
Flow without changing actual behaviour.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
  • Verified V +2
    • Anja Leichsenring +2
    • Wouter Wolters +1

Issues 1

Files 26

Show 6 more files

Review log 11

  1. Mr. Jenkins commented on patch set 1 06/02/13, 11:40

  2. Alexander Schnitzler uploaded patch set 2 06/02/13, 11:58

  3. Mr. Jenkins commented on patch set 2 06/02/13, 11:59

  4. Alexander Schnitzler uploaded patch set 3 06/02/13, 14:25

  5. Mr. Jenkins commented on patch set 3 06/02/13, 14:26

  6. Wouter Wolters commented on patch set 3 V +1 06/04/13, 17:17

    Can you check my inline comments?

    Result.php:277

    boolean

    ConjunctionValidator.php:36

    Remove here also \TYPO3\CMS\Extbase\Validation\Validator\ ??

    ObjectValidatorInterface.php:35

    Remove \TYPO3\CMS\Extbase\Validation\Validator\ here also ??

    RawValidator.php:36

    Remove \TYPO3\CMS\Extbase\Validation\Validator\ here also ??
  7. Alexander Schnitzler commented on patch set 3 06/04/13, 18:36

    You are right. I just backported the stuff from Flow so its also "wrong" there. Will provide another patchset.
  8. Alexander Schnitzler uploaded patch set 4 06/04/13, 18:45

  9. Wouter Wolters voted on patch set 4 V +1 CR +1 06/04/13, 18:48

  10. Anja Leichsenring voted on patch set 4 V +2 CR +2 06/04/13, 19:46

  11. Anja Leichsenring merged patch set 5 06/04/13, 19:46