21190[TASK] Make preperations for backporting Flow validation api
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Wouter Wolters +1
-
Verified V +2
- Anja Leichsenring +2
- Wouter Wolters +1
Issues 1
Files 26
- typo3/sysext/extbase/Classes/Error/Result.php1+125 −9
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+23 −1
- typo3/sysext/extbase/Classes/Validation/Validator/AbstractCompositeValidator.php+46 −1
- typo3/sysext/extbase/Classes/Validation/Validator/AbstractValidator.php+35 −0
- typo3/sysext/extbase/Classes/Validation/Validator/AlphanumericValidator.php+3 −1
- typo3/sysext/extbase/Classes/Validation/Validator/ConjunctionValidator.php1+4 −4
- typo3/sysext/extbase/Classes/Validation/Validator/DateTimeValidator.php+5 −2
- typo3/sysext/extbase/Classes/Validation/Validator/DisjunctionValidator.php+4 −5
- typo3/sysext/extbase/Classes/Validation/Validator/EmailAddressValidator.php+4 −1
- typo3/sysext/extbase/Classes/Validation/Validator/FloatValidator.php+5 −2
- typo3/sysext/extbase/Classes/Validation/Validator/IntegerValidator.php+5 −2
- typo3/sysext/extbase/Classes/Validation/Validator/NotEmptyValidator.php+5 −2
- typo3/sysext/extbase/Classes/Validation/Validator/NumberRangeValidator.php+4 −1
- typo3/sysext/extbase/Classes/Validation/Validator/NumberValidator.php+5 −2
- typo3/sysext/extbase/Classes/Validation/Validator/ObjectValidatorInterface.php1+7 −3
- typo3/sysext/extbase/Classes/Validation/Validator/RawValidator.php1+5 −2
- typo3/sysext/extbase/Classes/Validation/Validator/RegularExpressionValidator.php+5 −3
- typo3/sysext/extbase/Classes/Validation/Validator/StringLengthValidator.php+5 −2
- typo3/sysext/extbase/Classes/Validation/Validator/StringValidator.php+5 −2
- typo3/sysext/extbase/Classes/Validation/Validator/TextValidator.php+5 −2
Show 6 more files
- typo3/sysext/extbase/Classes/Validation/Validator/ValidatorInterface.php+1 −12
- typo3/sysext/extbase/Classes/Validation/Error.php+5 −4
- typo3/sysext/extbase/Classes/Validation/Exception.php+3 −0
- typo3/sysext/extbase/Classes/Validation/ValidatorResolver.php+14 −14
- typo3/sysext/extbase/Tests/Unit/Error/ResultTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Validation/ValidatorResolverTest.php+17 −17
Review log 11
-
Mr. Jenkins commented on patch set 1 06/02/13, 11:40
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8972/ : SUCCESS -
Alexander Schnitzler uploaded patch set 2 06/02/13, 11:58
-
Mr. Jenkins commented on patch set 2 06/02/13, 11:59
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8973/ : SUCCESS -
Alexander Schnitzler uploaded patch set 3 06/02/13, 14:25
-
Mr. Jenkins commented on patch set 3 06/02/13, 14:26
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8974/ : SUCCESS -
Wouter Wolters commented on patch set 3 V +1 06/04/13, 17:17
Can you check my inline comments?Result.php:277booleanConjunctionValidator.php:36Remove here also \TYPO3\CMS\Extbase\Validation\Validator\ ??ObjectValidatorInterface.php:35Remove \TYPO3\CMS\Extbase\Validation\Validator\ here also ??RawValidator.php:36Remove \TYPO3\CMS\Extbase\Validation\Validator\ here also ?? -
Alexander Schnitzler commented on patch set 3 06/04/13, 18:36
You are right. I just backported the stuff from Flow so its also "wrong" there. Will provide another patchset. -
Alexander Schnitzler uploaded patch set 4 06/04/13, 18:45
-
Wouter Wolters voted on patch set 4 V +1 CR +1 06/04/13, 18:48
-
Anja Leichsenring voted on patch set 4 V +2 CR +2 06/04/13, 19:46
-
Anja Leichsenring merged patch set 5 06/04/13, 19:46