Review main Merged

21197[TASK] EXT: t3skin - extract table styling

Felix Kopp CR +2 V +2 Normal +100 −89 updated 06/04/13, 22:53

Commit message

In order to be able to introduce common table css definition,
CSS must be concentrated in a common file "main_table.css".

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
    • Susi Moog +1
  • Verified V +2
    • Markus Klein +2
    • Wouter Wolters +1

Issues 1

Files 5

Review log 7

  1. Mr. Jenkins commented on patch set 1 06/03/13, 09:05

  2. Felix Kopp uploaded patch set 2 06/03/13, 09:07

  3. Mr. Jenkins commented on patch set 2 06/03/13, 09:08

  4. Susi Moog commented on patch set 2 06/03/13, 20:09

    Looks good to me, but someone else must approve
  5. Wouter Wolters commented on patch set 2 V +1 CR +1 06/04/13, 16:55

    Picked all removed code in a file and removed it piece by piece to see if it is added again. All is still there:)
  6. Markus Klein commented on patch set 2 V +2 CR +2 06/04/13, 22:53

    Tested by having a look at tables and having them still in the known look.
  7. Markus Klein merged patch set 3 06/04/13, 22:53