Review TYPO3_6-1 Merged

21220[BUGFIX] FormFieldVH->getPropertyValue() must work without form object

Alexander Schnitzler CR +2 V +2 Easy +3 −0 updated 06/04/13, 19:22

Commit message

Since the new property mapper is active by default it is
possible to create forms without object="{object}", e.g.
using a newAction. This leads to some view helpers throwing
an exception as they rely on a present object to receive the
property value. As this object may not be present a missing
check has to be added to method getPropertyValue().

This check also exists in Flow.Fluid and is necessary to
fix malfunctioning view helpers.

Review

  • Code review CR +2
    • Alexander Schnitzler +2
    • Wouter Wolters +1
  • Verified V +2
    • Alexander Schnitzler +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 3

  1. Wouter Wolters voted on patch set 1 V +1 CR +1 06/04/13, 19:21

  2. Alexander Schnitzler voted on patch set 1 V +2 CR +2 06/04/13, 19:22

  3. Alexander Schnitzler merged patch set 2 06/04/13, 19:22