Review main Merged

21242[BUGFIX] Use cHash in language menu links if necessary

Dmitry Dulepov CR +2 V +2 Easy +35 −0 updated 03/13/14, 08:23

Commit message

Current menu implementation does not add the cHash in language
menus. This causes a non-cached page and performance
degradation if the page contains parameters and a user switches
between languages. Together with extensions like RealURL it
can become a long time issue because of the caching of wrong
URLs. The fix implements analysis for the query string and
relevant parameters to decide whether the cHash should be
added or not.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Jigal van Hemert +1
    • Philipp Gampe +1
  • Verified V +2
    • Georg Ringer +2
    • Philipp Gampe +1

Issues 1

Files 1

Review log 14

  1. Wouter Wolters voted on patch set 1 CR +1 06/05/13, 17:48

  2. Philipp Gampe commented on patch set 1 06/06/13, 16:01

    nitpick

    AbstractMenuContentObject.php:217

    use a semicolon instead of the opening brace (the closing one is missing anyway).
  3. Dmitry Dulepov uploaded patch set 2 02/26/14, 11:37

  4. Dmitry Dulepov commented on patch set 2 02/26/14, 11:37

    Rebased & fixed note from Philipp.
  5. Mr. Jenkins commented on patch set 2 02/26/14, 11:50

  6. Philipp Gampe commented on patch set 2 03/12/14, 12:53

    tested, works I suggest to change this to a bugfix as IMHO this is a bug in TYPO3 link generation. Hint for testers: Remember to set HMENU.addQueryString = 1.
  7. Philipp Gampe voted on patch set 2 V +1 CR +1 03/12/14, 12:53

  8. Philipp Gampe commented on patch set 2 03/12/14, 12:59

    AbstractMenuContentObject.php:930

    early return here?
  9. Philipp Gampe uploaded patch set 3 03/12/14, 13:01

  10. Philipp Gampe commented on patch set 3 V +1 CR +1 03/12/14, 13:02

    rebased and changed to bugfix
  11. Mr. Jenkins commented on patch set 3 03/12/14, 13:22

  12. Jigal van Hemert voted on patch set 3 CR +1 03/12/14, 13:33

  13. Georg Ringer voted on patch set 3 V +2 CR +2 03/13/14, 08:23

  14. Georg Ringer merged patch set 4 03/13/14, 08:23