21242[BUGFIX] Use cHash in language menu links if necessary
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Jigal van Hemert +1
- Philipp Gampe +1
-
Verified V +2
- Georg Ringer +2
- Philipp Gampe +1
Issues 1
Files 1
Review log 14
-
Wouter Wolters voted on patch set 1 CR +1 06/05/13, 17:48
-
Philipp Gampe commented on patch set 1 06/06/13, 16:01
nitpickAbstractMenuContentObject.php:217use a semicolon instead of the opening brace (the closing one is missing anyway). -
Dmitry Dulepov uploaded patch set 2 02/26/14, 11:37
-
Dmitry Dulepov commented on patch set 2 02/26/14, 11:37
Rebased & fixed note from Philipp. -
Mr. Jenkins commented on patch set 2 02/26/14, 11:50
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14322/ : SUCCESS -
Philipp Gampe commented on patch set 2 03/12/14, 12:53
tested, works I suggest to change this to a bugfix as IMHO this is a bug in TYPO3 link generation. Hint for testers: Remember to set HMENU.addQueryString = 1. -
Philipp Gampe voted on patch set 2 V +1 CR +1 03/12/14, 12:53
-
Philipp Gampe commented on patch set 2 03/12/14, 12:59
AbstractMenuContentObject.php:930early return here? -
Philipp Gampe uploaded patch set 3 03/12/14, 13:01
-
Philipp Gampe commented on patch set 3 V +1 CR +1 03/12/14, 13:02
rebased and changed to bugfix -
Mr. Jenkins commented on patch set 3 03/12/14, 13:22
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/14946/ : SUCCESS -
Jigal van Hemert voted on patch set 3 CR +1 03/12/14, 13:33
-
Georg Ringer voted on patch set 3 V +2 CR +2 03/13/14, 08:23
-
Georg Ringer merged patch set 4 03/13/14, 08:23