Review main Merged

21246[BUGFIX] Bad English in TCEforms: "Edit Pagecontent" and "fontface"

Dmitry Dulepov CR +2 V +2 Easy +11 −11 updated 06/08/13, 19:02

Commit message

Core language files contain the words "Pagecontent" and "fontface",
which both must be two separate words.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Bernhard Kraft +1
  • Verified V +2
    • Wouter Wolters +2
    • Bernhard Kraft +1

Issues 1

Files 3

Review log 8

  1. Markus Klein voted on patch set 1 V +1 CR +1 06/05/13, 14:45

  2. Wouter Wolters voted on patch set 1 V +1 CR +1 06/05/13, 16:56

  3. Bernhard Kraft commented on patch set 1 06/06/13, 08:11

    I don't know wheter changing "Pagecontent" to "Page content" really makes sense. In the CMS world "Pagecontent" is a noun for itself and the word "screenshot" which you also split up in your patch shows that compound words are not unusual in English. I guess we should use "Pagecontent" when we speak of tt_content records and "Page content" when we speak of the content on a page in general in which case the two words are usually built into some sentence and should get written "page content" anyways like in: "If you modify page content the CMS keeps track of every change."

    locallang_csh_be_groups.xlf:153

    By consulting wikipedia I think it is rather "screenshot" not "screen shot": http://en.wiktionary.org/wiki/screenshot
  4. Bernhard Kraft uploaded patch set 2 06/08/13, 18:50

  5. Mr. Jenkins commented on patch set 2 06/08/13, 18:51

  6. Bernhard Kraft commented on patch set 2 V +1 CR +1 06/08/13, 18:53

    I just changed the commit message because you not only changed "Pagecontent" but also "fontface". Else +1 from me.
  7. Wouter Wolters voted on patch set 2 V +2 CR +2 06/08/13, 19:02

  8. Wouter Wolters merged patch set 3 06/08/13, 19:02