21246[BUGFIX] Bad English in TCEforms: "Edit Pagecontent" and "fontface"
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Bernhard Kraft +1
-
Verified V +2
- Wouter Wolters +2
- Bernhard Kraft +1
Issues 1
Files 3
Review log 8
-
Markus Klein voted on patch set 1 V +1 CR +1 06/05/13, 14:45
-
Wouter Wolters voted on patch set 1 V +1 CR +1 06/05/13, 16:56
-
Bernhard Kraft commented on patch set 1 06/06/13, 08:11
I don't know wheter changing "Pagecontent" to "Page content" really makes sense. In the CMS world "Pagecontent" is a noun for itself and the word "screenshot" which you also split up in your patch shows that compound words are not unusual in English. I guess we should use "Pagecontent" when we speak of tt_content records and "Page content" when we speak of the content on a page in general in which case the two words are usually built into some sentence and should get written "page content" anyways like in: "If you modify page content the CMS keeps track of every change."locallang_csh_be_groups.xlf:153By consulting wikipedia I think it is rather "screenshot" not "screen shot": http://en.wiktionary.org/wiki/screenshot -
Bernhard Kraft uploaded patch set 2 06/08/13, 18:50
-
Mr. Jenkins commented on patch set 2 06/08/13, 18:51
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8999/ : SUCCESS -
Bernhard Kraft commented on patch set 2 V +1 CR +1 06/08/13, 18:53
I just changed the commit message because you not only changed "Pagecontent" but also "fontface". Else +1 from me. -
Wouter Wolters voted on patch set 2 V +2 CR +2 06/08/13, 19:02
-
Wouter Wolters merged patch set 3 06/08/13, 19:02