21258[BUGFIX] FileLogWriter ignores log file configuration
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Helmut Hummel +1
-
Verified V +2
- Markus Klein +2
- Helmut Hummel +1
Issues 1
Files 2
Review log 28
Show 3 earlier messages
-
Mr. Jenkins commented on patch set 1 06/06/13, 13:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8989/ : SUCCESS -
Steffen Gebert commented on patch set 1 06/06/13, 14:19
I'm not so sure.. I believe the reason why this is a static variable was to not open the file multiple times, but I see the problem caused by this. Is there one FileLogWriter instance only per log file? Or is always a new one created, when a FileLogWriter for a certain file is requested? If there's only one, I see no problem in removing this. Otherwise we might make the static variable an array and hold the handle on a per-logfile basis. -
Steffen Müller commented on patch set 1 06/06/13, 14:54
I see. What would you use as kay? the path or a hash of it?
-
Steffen Müller uploaded patch set 2 06/06/13, 15:17
-
Mr. Jenkins commented on patch set 2 06/06/13, 15:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8990/ : SUCCESS -
Alexander Opitz voted on patch set 2 CR +1 06/07/13, 10:07
-
Steffen Müller commented on patch set 2 06/07/13, 12:09
I did not test if a file is served by just one filehandle within a request. This should be done before merging. -
Steffen Müller uploaded patch set 3 06/08/13, 12:49
-
Mr. Jenkins commented on patch set 3 06/08/13, 12:50
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8996/ : SUCCESS -
Alexander Opitz voted on patch set 3 CR +1 06/08/13, 22:11
-
Helmut Hummel voted on patch set 3 CR +1 06/10/13, 09:18
-
Markus Klein commented on patch set 3 06/10/13, 09:21
FileWriter.php:100Move this check into the openLogFile() method. -
Helmut Hummel commented on patch set 3 06/10/13, 09:30
FileWriter.php:100Replygood idea -
Steffen Müller commented on patch set 3 06/10/13, 10:03
FileWriter.php:100Replywhy? would result in one more superfluous function call -
Steffen Müller uploaded patch set 4 06/10/13, 10:28
-
Mr. Jenkins commented on patch set 4 06/10/13, 10:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9003/ : SUCCESS -
Markus Klein voted on patch set 4 CR +2 06/10/13, 10:59
-
Helmut Hummel commented on patch set 4 CR -1 06/10/13, 13:37
will create tests for this one -
Helmut Hummel commented on patch set 4 V -1 06/10/13, 14:14
FileWriter.php:136Must be "$this->logFile" ! -
Helmut Hummel uploaded patch set 5 06/10/13, 14:14
-
Mr. Jenkins commented on patch set 5 06/10/13, 14:15
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9012/ : SUCCESS -
Helmut Hummel uploaded patch set 6 06/10/13, 14:17
-
Mr. Jenkins commented on patch set 6 06/10/13, 14:17
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9013/ : SUCCESS -
Helmut Hummel voted on patch set 6 V +1 CR +1 06/10/13, 14:18
-
Markus Klein commented on patch set 6 CR +2 06/10/13, 15:12
Thx Helmut. -
Steffen Müller commented on patch set 6 06/10/13, 15:56
Wow - I didn't know this kind of unitTest was possilbe. Thanks for that. I have green bar! AFAIK a +1 verified is missing. -
Markus Klein commented on patch set 6 V +2 06/10/13, 15:59
You got my verified -
Markus Klein merged patch set 7 06/10/13, 15:59