Review main Merged

21306[FEATURE] Hook for tsfe::checkEnableFields

André Haehnel CR +2 V +2 Easy +10 −0 updated 06/23/13, 10:43

Commit message

This hook for tsfe::checkEnableFields allows extensions to provide
additional rules for page visibility when parent pages have
"extend to subpages" activated.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 11

  1. Mr. Jenkins commented on patch set 1 06/10/13, 08:41

  2. Christian Weiske commented on patch set 1 06/11/13, 15:11

    I'd like to see $row and $byPassGroupCheck to be passed to the hook, too.
  3. Christian Weiske uploaded patch set 2 06/11/13, 15:22

  4. Mr. Jenkins commented on patch set 2 06/11/13, 15:23

  5. André Haehnel commented on patch set 2 V +1 06/21/13, 06:59

    Looks good to me. All data objects passed.
  6. Rico Sonntag commented on patch set 2 V +1 CR +1 06/21/13, 09:39

    Looks good to me.
  7. Christian Kuhn uploaded patch set 3 06/21/13, 18:12

  8. Christian Kuhn commented on patch set 3 V +1 CR +1 06/21/13, 18:13

    Fine with me. I just added a comment to the hook explaining the purpose of the return statement.
  9. Mr. Jenkins commented on patch set 3 06/21/13, 18:13

  10. Anja Leichsenring voted on patch set 3 V +2 CR +2 06/23/13, 10:42

  11. Anja Leichsenring merged patch set 4 06/23/13, 10:43