21309[BUGFIX][Cache] Typo3DbBackend forgets tag entries in flushByTag
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Christian Kuhn +1
-
Verified V +2
- Wouter Wolters +2
- Christian Kuhn +1
Issues 1
Files 2
Review log 14
-
Mr. Jenkins commented on patch set 1 06/10/13, 11:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9005/ : SUCCESS -
Christian Kuhn commented on patch set 1 CR -1 06/11/13, 09:43
The class is already covered by tests and since you are requesting a bugfix for so many version below to 4.5, this case should be unit tested. -
Christian Zenker uploaded patch set 2 06/12/13, 14:46
-
Mr. Jenkins commented on patch set 2 06/12/13, 14:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9046/ : SUCCESS -
Alexander Opitz voted on patch set 2 CR +1 06/30/13, 12:08
-
Christian Kuhn updated the commit message in patch set 2 07/05/13, 23:03
-
Mr. Jenkins commented on patch set 3 07/05/13, 23:04
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9438/ : SUCCESS -
Christian Kuhn commented on patch set 3 07/05/13, 23:06
+1 on (drunken) reading, sounds logical. The test case should (probably) be extended to a second cache entry with a shared and other tags and see if the other tag entries are deleted, too. Will give it a shot tomorrow. -
Christian Kuhn uploaded patch set 4 07/06/13, 13:51
-
Christian Kuhn voted on patch set 4 V +1 CR +1 07/06/13, 13:51
-
Mr. Jenkins commented on patch set 4 07/06/13, 13:52
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9459/ : SUCCESS -
Wouter Wolters voted on patch set 4 V +2 CR +2 07/06/13, 14:02
-
Wouter Wolters merged patch set 5 07/06/13, 14:02
-
Wouter Wolters commented on patch set 5 07/06/13, 14:02
Cherry Picked This patchset was cherry picked to change: I7096e63cf823633f0c8a47f698bd475d7d02b83c