Review main Merged

21309[BUGFIX][Cache] Typo3DbBackend forgets tag entries in flushByTag

Christian Zenker CR +2 V +2 Easy +18 −1 updated 07/06/13, 14:02

Commit message

flushByTags removes cache entries tagged with a given tag, but
if those cache entries have other tags assigned, they are not
deleted in the tags table.
The patch fixes this with an additional query.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1

Issues 1

Files 2

Review log 14

  1. Mr. Jenkins commented on patch set 1 06/10/13, 11:47

  2. Christian Kuhn commented on patch set 1 CR -1 06/11/13, 09:43

    The class is already covered by tests and since you are requesting a bugfix for so many version below to 4.5, this case should be unit tested.
  3. Christian Zenker uploaded patch set 2 06/12/13, 14:46

  4. Mr. Jenkins commented on patch set 2 06/12/13, 14:47

  5. Alexander Opitz voted on patch set 2 CR +1 06/30/13, 12:08

  6. Christian Kuhn updated the commit message in patch set 2 07/05/13, 23:03

  7. Mr. Jenkins commented on patch set 3 07/05/13, 23:04

  8. Christian Kuhn commented on patch set 3 07/05/13, 23:06

    +1 on (drunken) reading, sounds logical. The test case should (probably) be extended to a second cache entry with a shared and other tags and see if the other tag entries are deleted, too. Will give it a shot tomorrow.
  9. Christian Kuhn uploaded patch set 4 07/06/13, 13:51

  10. Christian Kuhn voted on patch set 4 V +1 CR +1 07/06/13, 13:51

  11. Mr. Jenkins commented on patch set 4 07/06/13, 13:52

  12. Wouter Wolters voted on patch set 4 V +2 CR +2 07/06/13, 14:02

  13. Wouter Wolters merged patch set 5 07/06/13, 14:02

  14. Wouter Wolters commented on patch set 5 07/06/13, 14:02

    Cherry Picked This patchset was cherry picked to change: I7096e63cf823633f0c8a47f698bd475d7d02b83c