21328[BUGFIX] Exception on thumbnail generation in TCA
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Alexander Opitz +1
- Ingo Pfennigstorf +1
-
Verified V +2
- Markus Klein +2
- Ingo Pfennigstorf +1
Files 1
Review log 22
-
Mr. Jenkins commented on patch set 1 CR -1 V -1 06/10/13, 18:00
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/9019/ : FAILURE -
Stefan Galinski updated the commit message in patch set 1 06/10/13, 18:01
-
Mr. Jenkins commented on patch set 2 06/10/13, 18:01
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9020/ : SUCCESS -
Alexander Opitz commented on patch set 2 06/10/13, 20:51
Shouldn't we write something into the error log instead of the strong tag? -
Markus Klein commented on patch set 2 06/10/13, 22:15
Yes, adding a log entry is a good idea. -
Stefan Galinski commented on patch set 2 06/11/13, 10:46
Then just as an addition, because the user must be informed that the file could not be found! -
Stefan Galinski commented on patch set 2 06/11/13, 10:48
And maybe a flash message instead of the strong tag? -
Markus Klein commented on patch set 2 06/11/13, 11:17
Log for the Admin FlashMsg for the User Text instead of Thumb "No Pic" -
Georg Ringer commented on patch set 2 CR -1 06/12/13, 11:38
FormEngine.php:2375use htmlspecialchars() -
Stefan Galinski uploaded patch set 3 06/17/13, 20:25
-
Mr. Jenkins commented on patch set 3 06/17/13, 20:25
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9073/ : SUCCESS -
Alexander Opitz commented on patch set 3 06/18/13, 06:50
FormEngine.php:2393I'm against htmlspecialcharing data that you do not output by yourself as html. But FlashMessage::render() don't do htmlspecialchar, which is a bug IMHO. For GeneralUtility::syslog, you don't know what sysLog will do with the data, if it hands out the data to a unix syslog system you will see all this special chars and it isn't nice to read the message. -
Markus Klein commented on patch set 3 CR -1 06/18/13, 12:49
FormEngine.php:2393ReplyI fully agree! -
Stefan Galinski uploaded patch set 4 06/18/13, 16:09
-
Mr. Jenkins commented on patch set 4 06/18/13, 16:10
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9078/ : SUCCESS -
Stefan Galinski commented on patch set 3 06/18/13, 16:10
The new patchset just removes the htmlspecialchars calls on the sysLog message.FormEngine.php:2393ReplyDone -
Markus Klein voted on patch set 4 CR +2 06/18/13, 20:22
-
Alexander Opitz voted on patch set 4 CR +1 06/19/13, 07:03
-
Ingo Pfennigstorf commented on patch set 4 07/05/13, 11:57
In my 6.1 a TYPO3\CMS\Core\Resource\Exception\FolderDoesNotExistException thrown is additionaly thrown. so maybe BackendUtility needs also to be adopted -
Ingo Pfennigstorf commented on patch set 4 V +1 CR +1 07/05/13, 12:44
Ok, had to clear cache and relogin to the backend. So now it works -
Markus Klein voted on patch set 4 V +2 07/05/13, 12:45
-
Markus Klein merged patch set 5 07/05/13, 12:45