Review main Merged

21328[BUGFIX] Exception on thumbnail generation in TCA

Stefan Galinski CR +2 V +2 Easy +27 −3 updated 07/05/13, 12:45

Commit message

In order to test this you are needing a non-FAL
TCA file reference field. Just reference something
here, remove the reference in the filesystem again
and reload the TCA of the record. An exception will
be thrown, because the file isn't available anymore.

Review

  • Code review CR +2
    • Markus Klein +2
    • Alexander Opitz +1
    • Ingo Pfennigstorf +1
  • Verified V +2
    • Markus Klein +2
    • Ingo Pfennigstorf +1

Files 1

Review log 22

  1. Mr. Jenkins commented on patch set 1 CR -1 V -1 06/10/13, 18:00

  2. Stefan Galinski updated the commit message in patch set 1 06/10/13, 18:01

  3. Mr. Jenkins commented on patch set 2 06/10/13, 18:01

  4. Alexander Opitz commented on patch set 2 06/10/13, 20:51

    Shouldn't we write something into the error log instead of the strong tag?
  5. Markus Klein commented on patch set 2 06/10/13, 22:15

    Yes, adding a log entry is a good idea.
  6. Stefan Galinski commented on patch set 2 06/11/13, 10:46

    Then just as an addition, because the user must be informed that the file could not be found!
  7. Stefan Galinski commented on patch set 2 06/11/13, 10:48

    And maybe a flash message instead of the strong tag?
  8. Markus Klein commented on patch set 2 06/11/13, 11:17

    Log for the Admin FlashMsg for the User Text instead of Thumb "No Pic"
  9. Georg Ringer commented on patch set 2 CR -1 06/12/13, 11:38

    FormEngine.php:2375

    use htmlspecialchars()
  10. Stefan Galinski uploaded patch set 3 06/17/13, 20:25

  11. Mr. Jenkins commented on patch set 3 06/17/13, 20:25

  12. Alexander Opitz commented on patch set 3 06/18/13, 06:50

    FormEngine.php:2393

    I'm against htmlspecialcharing data that you do not output by yourself as html. But FlashMessage::render() don't do htmlspecialchar, which is a bug IMHO. For GeneralUtility::syslog, you don't know what sysLog will do with the data, if it hands out the data to a unix syslog system you will see all this special chars and it isn't nice to read the message.
  13. Markus Klein commented on patch set 3 CR -1 06/18/13, 12:49

    FormEngine.php:2393 Reply

    I fully agree!
  14. Stefan Galinski uploaded patch set 4 06/18/13, 16:09

  15. Mr. Jenkins commented on patch set 4 06/18/13, 16:10

  16. Stefan Galinski commented on patch set 3 06/18/13, 16:10

    The new patchset just removes the htmlspecialchars calls on the sysLog message.

    FormEngine.php:2393 Reply

    Done
  17. Markus Klein voted on patch set 4 CR +2 06/18/13, 20:22

  18. Alexander Opitz voted on patch set 4 CR +1 06/19/13, 07:03

  19. Ingo Pfennigstorf commented on patch set 4 07/05/13, 11:57

    In my 6.1 a TYPO3\CMS\Core\Resource\Exception\FolderDoesNotExistException thrown is additionaly thrown. so maybe BackendUtility needs also to be adopted
  20. Ingo Pfennigstorf commented on patch set 4 V +1 CR +1 07/05/13, 12:44

    Ok, had to clear cache and relogin to the backend. So now it works
  21. Markus Klein voted on patch set 4 V +2 07/05/13, 12:45

  22. Markus Klein merged patch set 5 07/05/13, 12:45