Review main Merged

21366[BUGFIX] Sorting ignored in "Template Overview"

Reinhard Führicht CR +2 V +2 Easy +13 −5 updated 06/20/15, 14:16

Commit message

The overview of all TS templates shows a tree like view listing
of all pages having a ts template on them.
But this view doesn't sort the pages by "sorting" like
in the pagetree.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Benni Mack +1
  • Verified V +2
    • Wouter Wolters +2
    • Benni Mack +1

Issues 1

Files 1

Review log 25

  1. Mr. Jenkins commented on patch set 1 06/12/13, 14:21

  2. Alexander Opitz voted on patch set 1 CR +1 06/12/13, 14:40

  3. Helmut Hummel commented on patch set 1 V -1 CR -1 06/25/13, 13:40

    "GROUP BY pages.sorting" is certainly not a good idea
  4. Helmut Hummel uploaded patch set 2 06/25/13, 13:43

  5. Mr. Jenkins commented on patch set 2 06/25/13, 13:44

  6. Helmut Hummel uploaded patch set 3 06/25/13, 13:44

  7. Mr. Jenkins commented on patch set 3 06/25/13, 13:45

  8. Helmut Hummel voted on patch set 3 V +1 CR +1 06/25/13, 13:45

  9. Wouter Wolters commented on patch set 3 CR +1 06/25/13, 13:46

    Test will follow this evening.
  10. Helmut Hummel commented on patch set 3 06/25/13, 13:51

    TypoScriptTemplateModuleController.php:193

    removed $templateArray on purpose. it not used anywhere
  11. Anja Leichsenring commented on patch set 3 V -1 06/25/13, 16:17

    I can see no effect. Please feel free to overrule my vote, maybe thats just me. Will test again tonight.
  12. Wouter Wolters commented on patch set 3 V -1 06/25/13, 17:11

    Will investigate further.

    TypoScriptTemplateModuleController.php:206

    The function setInPageArray ignores the sorting an doesn't make the same tree as the pagetree.
  13. Wouter Wolters commented on patch set 3 06/25/13, 18:39

    Sorting here doesn't help to solve this problem. The setInPageArray function doesn't care about sorting and the input for this method is BEgetRootLine. Take for example a tree like: Page1 -> sorting 128 Subpage1 -> sorting 128 Subpage2 -> sorting 256 Subsubpage1 -> sorting 8 Here the rootline of 8 will be processed first, which will result in a tree that is dirrerent then the PageTree.
  14. Anja Leichsenring commented on patch set 3 10/06/13, 08:36

    Someone still interested in this patch? If so, please raise your hand. However, I vote against backporting below 6.0
  15. Wouter Wolters wrote 10/16/13, 19:40

    Topic set to "tstemplate".
  16. Anja Leichsenring wrote 12/07/14, 20:20

    Removed the following approvals: * Verified-1 by Anja Leichsenring <aleichsenring@ab-softlab.de>
  17. Benni Mack uploaded patch set 4 01/08/15, 20:05

  18. Stefan Froemken voted on patch set 4 CR +1 01/08/15, 20:10

  19. Wouter Wolters commented on patch set 4 V -1 01/19/15, 22:28

    Sorry still doesn't work for me
  20. Benni Mack uploaded patch set 5 06/19/15, 13:46

  21. Benni Mack commented on patch set 5 CR +1 V +1 06/19/15, 13:48

    Hey Wouter, Although this is not the final solution here, I think it covers around 90% of all cases when first sorting by the field "pid" then by "sorting". I would love to have this one in (and finally off the review list after two years) and then we can continue on improving this with a later patch.
  22. Wouter Wolters commented on patch set 5 06/19/15, 13:50

    Will check it this evening.
  23. Wouter Wolters commented on patch set 5 06/19/15, 20:55

    I lost my internet connection, so won't be today anymore, tomorrow another change.
  24. Wouter Wolters voted on patch set 5 V +2 CR +2 06/20/15, 14:16

  25. Wouter Wolters merged patch set 5 06/20/15, 14:16