Review main Abandoned

2139[BUGFIX] Fix clashing delimiter used by RTE Browse Links and FlexForms

Christian Jul Jensen CR 0 V 0 Easy +4 −4 updated 06/03/13, 20:49

Commit message

The browse links class uses colon as a delimiter for different parameters
passed on tree updates. One of these parameters is the field name. When in
a context of a FlexForm colon is also used as delimiter in the field name,
thus creating a mismatch in the parameters in browse links.

To fix this the delimiter in browse links is changed to semicolon

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 9

  1. Christian Jul Jensen commented on patch set 1 05/25/11, 09:17

    Thanks Stan, I will fix that and commit a new patchset
  2. Christian Jul Jensen uploaded patch set 2 05/25/11, 09:17

  3. Christian Jul Jensen commented on patch set 2 05/25/11, 09:17

    Stefan, to reproduce the bug install an extension that uses flexforms for configuration and has an RTE in it. Then open the link editor and browse around the tree.
  4. Stanislas Rolland commented on patch set 1 05/25/11, 09:17

    The same change would need to be applied to sysext/rtehtmlarea/mod4/class.tx_rtehtmlarea_select_image.php
  5. Stefan Neufeind commented on patch set 2 05/25/11, 09:17

    Looks good to me, but someone else must approve Can't reproduce the bug (without this patch) unfortunately (so I can't say "verified"). But looks fine and explanation seems to suggest it fixes some special case ...
  6. Kay Strobach commented on patch set 2 05/25/11, 09:17

    Verified; Looks good to me, but someone else must approve
  7. Mr. Jenkins commented on patch set 1 05/25/11, 09:17

  8. Mr. Jenkins commented on patch set 2 05/25/11, 09:17

  9. Christian Jul Jensen commented on patch set 2 05/25/11, 09:17

    Abandoned Guys, this turned out to be a problem with the xml of the flexforms, see the bug in forge for full description. Sorry for wasting your time.