21428[!!!][FEATURE] Backport recursive and allowing empty validation from Flow
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Markus Günther +1
- Marc Bastian Heinrichs +1
-
Verified V +2
- Anja Leichsenring +2
- Markus Günther +1
- Marc Bastian Heinrichs +1
Issues 2
Files 45
- typo3/sysext/extbase/Classes/Error/Result.php+27 −7
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+46 −16
- typo3/sysext/extbase/Classes/Validation/Exception/InvalidTypeHintException.phpnew+37 −0
- typo3/sysext/extbase/Classes/Validation/Validator/AbstractCompositeValidator.php+65 −6
- typo3/sysext/extbase/Classes/Validation/Validator/AbstractObjectValidator.php+10 −0
- typo3/sysext/extbase/Classes/Validation/Validator/AbstractValidator.php+3 −1
- typo3/sysext/extbase/Classes/Validation/Validator/AlphanumericValidator.php+3 −9
- typo3/sysext/extbase/Classes/Validation/Validator/BooleanValidator.php+3 −6
- typo3/sysext/extbase/Classes/Validation/Validator/CollectionValidator.php2new+121 −0
- typo3/sysext/extbase/Classes/Validation/Validator/ConjunctionValidator.php+14 −3
- typo3/sysext/extbase/Classes/Validation/Validator/DateTimeValidator.php+1 −2
- typo3/sysext/extbase/Classes/Validation/Validator/DisjunctionValidator.php+24 −13
- typo3/sysext/extbase/Classes/Validation/Validator/EmailAddressValidator.php+18 −11
- typo3/sysext/extbase/Classes/Validation/Validator/FloatValidator.php+13 −13
- typo3/sysext/extbase/Classes/Validation/Validator/GenericObjectValidator.php6+125 −57
- typo3/sysext/extbase/Classes/Validation/Validator/IntegerValidator.php+8 −12
- typo3/sysext/extbase/Classes/Validation/Validator/NotEmptyValidator.php1+8 −6
- typo3/sysext/extbase/Classes/Validation/Validator/NumberRangeValidator.php1+37 −26
- typo3/sysext/extbase/Classes/Validation/Validator/NumberValidator.php+3 −6
- typo3/sysext/extbase/Classes/Validation/Validator/ObjectValidatorInterface.php+9 −0
Show 25 more files
- typo3/sysext/extbase/Classes/Validation/Validator/RawValidator.php+4 −36
- typo3/sysext/extbase/Classes/Validation/Validator/RegularExpressionValidator.php+12 −24
- typo3/sysext/extbase/Classes/Validation/Validator/StringLengthValidator.php+29 −16
- typo3/sysext/extbase/Classes/Validation/Validator/StringValidator.php1+2 −6
- typo3/sysext/extbase/Classes/Validation/Validator/TextValidator.php+8 −6
- typo3/sysext/extbase/Classes/Validation/Validator/ValidatorInterface.php2+26 −0
- typo3/sysext/extbase/Classes/Validation/ValidatorResolver.php9+235 −90
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/BeforeExtbase14/AlphanumericValidatorTest.php+7 −4
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/BeforeExtbase14/DateTimeValidatorTest.php+5 −3
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/BeforeExtbase14/EmailAddressValidatorTest.php+5 −3
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/BeforeExtbase14/FloatValidatorTest.php+5 −3
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/BeforeExtbase14/GenericObjectValidatorTest.php+6 −0
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/BeforeExtbase14/IntegerValidatorTest.php+5 −3
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/BeforeExtbase14/NotEmptyValidatorTest.php+7 −4
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/BeforeExtbase14/NumberRangeValidatorTest.php+9 −5
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/BeforeExtbase14/NumberValidatorTest.php+5 −3
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/BeforeExtbase14/RawValidatorTest.php+7 −6
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/BeforeExtbase14/RegularExpressionValidatorTest.php+3 −2
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/BeforeExtbase14/StringLengthValidatorTest.php+23 −13
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/BeforeExtbase14/TextValidatorTest.php+9 −5
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/DisjunctionValidatorTest.php+1 −0
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/GenericObjectValidatorTest.php+26 −0
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/StringLengthValidatorTest.php+42 −20
- typo3/sysext/extbase/Tests/Unit/Validation/ValidatorResolverTest.php+16 −22
- typo3/sysext/fluid/Classes/ViewHelpers/Form/ValidationResultsViewHelper.php+1 −1
Review log 35
Show 10 earlier messages
-
Alexander Schnitzler rebased onto patch set 1 06/21/13, 10:48
-
Mr. Jenkins commented on patch set 2 06/21/13, 10:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9120/ : SUCCESS -
Alexander Schnitzler uploaded patch set 3 06/21/13, 10:57
-
Mr. Jenkins commented on patch set 3 06/21/13, 10:58
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9121/ : SUCCESS -
Alexander Schnitzler uploaded patch set 4 06/21/13, 12:17
-
Mr. Jenkins commented on patch set 4 06/21/13, 12:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9122/ : SUCCESS -
Stefan Froemken commented on patch set 4 V +1 06/21/13, 13:12
I have tested it on PHP 5.3 with all Extbase UnitTests. I created my own extension and it works with enabled PropertyMapper. The code review is a little bit too hard for me. -
Anja Leichsenring commented on patch set 4 V +1 06/23/13, 11:18
CollectionValidator.php:69why this early return here and in the branch above? Looks unnessessary.ValidatorInterface.php:43what is the purpose of commented functions?ValidatorResolver.php:133instead of throwing and immediatly catching the exception, create the syslog entry here?ValidatorResolver.php:194use the ClassNameUtility here -
Alexander Schnitzler commented on patch set 4 06/23/13, 12:08
CollectionValidator.php:69ReplyIt's 100% TYPO3.FlowValidatorInterface.php:43Reply100% TYPO3.FlowValidatorResolver.php:194ReplyWill dig into it. -
Alexander Schnitzler commented on patch set 4 06/23/13, 12:12
ValidatorResolver.php:133ReplyExceptions can also be thrown in line 124, so I would like to have just one catch and log until we can get rid of the Exceptions at all.
-
Wouter Wolters commented on patch set 4 V +1 06/26/13, 19:17
Really clean patch, found some small thins. I only tested the Unit-tests. No real test with an extension.ValidatorResolver.php:133TYPO3\Flow\Validation\Validator\ValidatorInterface is the Flow name, can we have the Extbase name here?ValidatorResolver.php:137missing space after catchValidatorResolver.php:318sapce after foreachValidatorResolver.php:546space after foreach -
Alexander Schnitzler commented on patch set 4 V -1 06/26/13, 20:04
ValidatorResolver.php:194ReplyConfirmed this only works with namespaced Classes, so I have to adjust this again. -
Alexander Schnitzler uploaded patch set 5 06/28/13, 07:40
-
Mr. Jenkins commented on patch set 5 06/28/13, 07:41
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9250/ : SUCCESS -
Alexander Schnitzler uploaded patch set 6 06/28/13, 09:14
-
Mr. Jenkins commented on patch set 6 06/28/13, 09:15
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9251/ : SUCCESS -
Marc Bastian Heinrichs commented on patch set 6 07/02/13, 17:55
Resolves also #34838GenericObjectValidator.php:52Translation needed?GenericObjectValidator.php:249move to top of classGenericObjectValidator.php:255move to top of classNotEmptyValidator.php:74Don't think that we should change the timestampsStringValidator.php:51Change timestamp? -
Marc Bastian Heinrichs commented on patch set 6 07/02/13, 18:41
Btw. works as expected with a test extensionadd "in Extbase" -
Alexander Schnitzler commented on patch set 6 07/02/13, 20:48
GenericObjectValidator.php:249ReplyMoving these parts up makes the diff nearly unreviewable. I deliberately put these changes down here to make sure everybody can see the actual changes in this class. I want to create a patch afterwards that rearranges all this. -
Alexander Schnitzler commented on patch set 6 07/03/13, 09:54
GenericObjectValidator.php:52ReplyPlease let's also do this in another step. -
Alexander Schnitzler rebased onto patch set 6 07/03/13, 09:54
-
Alexander Schnitzler uploaded patch set 8 07/03/13, 09:55
-
Mr. Jenkins commented on patch set 7 07/03/13, 09:55
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9332/ : SUCCESS -
Marc Bastian Heinrichs commented on patch set 6 07/03/13, 09:56
GenericObjectValidator.php:249Replyis ok for me -
Mr. Jenkins commented on patch set 8 07/03/13, 09:56
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9333/ : SUCCESS -
Alexander Schnitzler commented on patch set 8 07/03/13, 10:35
-
Markus Günther commented on patch set 8 V +1 CR +1 07/04/13, 15:26
Great patch. Thank you Alex! Works fine with a test Extension, code look good and unit tests gives a green bar feeling. -
Marc Bastian Heinrichs commented on patch set 8 V +1 CR -1 07/04/13, 16:08
Sorry, that forgot this: it should also be noticed, that validators are allow empty values now, what is a breaking change - see Flow change http://forge.typo3.org/projects/package-typo3-flow/repository/revisions/9b627954f289d793b808db2ac19edc6a04c25426 Suggestion: [!!!][FEATURE] Backport Flow recursive and allowing empty validation This change enables recursive validation by backporting the TYPO3.Flow validation api. Also the validators allow empty values now. This is a breaking change if you expected the previous behavior. In order to make a property required you now need to add the NotEmptyValidator explicitly! This change also changes the validators required return type for the default property mapper before 6.1. Before this change the isValid method had to return a boolean value. Now this is not necessary anymore, because only the errors added by the validator are checked. -
Marc Bastian Heinrichs uploaded patch set 9 07/04/13, 16:12
-
Mr. Jenkins commented on patch set 9 07/04/13, 16:13
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9359/ : SUCCESS -
Marc Bastian Heinrichs commented on patch set 9 V +1 CR +1 07/04/13, 16:14
Changed the commit message only -
Markus Günther voted on patch set 9 V +1 CR +1 07/04/13, 16:17
-
Anja Leichsenring commented on patch set 9 V +2 CR +2 07/04/13, 16:20
thank you very much for the effort of backporting this nice and highly apprecciated feature. -
Anja Leichsenring merged patch set 10 07/04/13, 16:20
-
Markus Klein commented on patch set 10 04/29/14, 09:03
NumberRangeValidator.php:43Regression: http://forge.typo3.org/issues/58313 Missing startRange and endRange