Review main Merged

21471[BUGFIX] Fix reverse order handling of MediaProvider

Alexander Opitz CR +2 V +2 Easy +1 −1 updated 06/17/13, 14:21

Commit message

Fixing the variable used to test for valid providers in reverse order.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2

Issues 1

Files 1

Review log 8

  1. Alexander Opitz uploaded patch set 2 06/17/13, 07:42

  2. Markus Klein uploaded patch set 3 06/17/13, 07:48

  3. Markus Klein commented on patch set 3 V +1 CR +1 06/17/13, 07:48

    Fixed typos and text in commit message. Removed unused variable
  4. Markus Klein commented on patch set 3 V +2 CR +2 06/17/13, 07:50

    Merging as no-brainer
  5. Markus Klein merged patch set 4 06/17/13, 07:50

  6. Bastian Waidelich commented on patch set 4 06/17/13, 08:20

    Hey there, just a little comment. Please don't use placeholders for the "Resolves", "Fixes" & "Related" footer as they update the related issue, in this case http://forge.typo3.org/issues/1234 ;)
  7. Alexander Opitz commented on patch set 4 06/17/13, 08:35

    I know, but I dreamed a bit this morning while writing the commit message. ;)
  8. Mr. Jenkins commented on patch set 3 06/17/13, 14:21