Review TYPO3_6-1 Merged

21472[BUGFIX] Fix reverse order handling of MediaProvider

Markus Klein CR +2 V +2 Easy +1 −1 updated 06/17/13, 08:33

Commit message

Fixing the variable used to test for valid providers in reverse order.

Review

  • Code review CR +2
    • Markus Klein +2
    • Alexander Opitz +1
  • Verified V +2
    • Markus Klein +2
    • Alexander Opitz +1

Issues 1

Files 1

Review log 9

  1. Alexander Opitz commented on patch set 1 06/17/13, 07:58

    MediaWizardProviderManager.php:65

    Didn't took notice that we do not need the key, but if this is irrelevant we can remove also the TRUE from array_reverse
  2. Alexander Opitz uploaded patch set 2 06/17/13, 08:05

  3. Markus Klein commented on patch set 2 CR -1 06/17/13, 08:08

    I'd prefer not to change this in a backport
  4. Alexander Opitz commented on patch set 2 06/17/13, 08:14

    Yes, that's right, how we fix/change such things?
  5. Alexander Opitz uploaded patch set 3 06/17/13, 08:16

  6. Alexander Opitz voted on patch set 3 V +1 CR +1 06/17/13, 08:16

  7. Markus Klein commented on patch set 3 V +2 CR +2 06/17/13, 08:19

    Simply push a TASK patch. But I guess it's not worth the effort for just this single line.
  8. Markus Klein merged patch set 4 06/17/13, 08:19

  9. Alexander Opitz commented on patch set 4 06/17/13, 08:33

    Ah ok, thanks for information. :-)